Currently for SVE2 ACLE builtins, single tests are used to verify both
clang code generation (when the feature is available) and semantic
error/warning messages (when the feature is unavailable). This
patch moves the semantic testing for the target feature flag into
dedicated Sema tests.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks for working on this @RosieSumpter!
clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2.cpp | ||
---|---|---|
2 | (see my commen later on as well) I'd remove this target feature and move those BF16 tests to a different file. | |
14 | It would be nice if these operands have slightly more descriptive names. Additionally, you may be able to allocate these as globals so that they don't need to be passed as operands to the test function, e.g. svbool_t pg; | |
4993 | I think you'll need to move these to a separate test file where the RUN line has only +sve2 (and not +bf16) |
- Changed operand names to be more descriptive
- Made int/uint/float variables global
- Moved bfloat tests into a separate file
clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2_bfloat.cpp | ||
---|---|---|
9 | Can you wrap these in SVE_ACLE_FUNC and add an extra RUN line for these? |
- Added REQUIRES: aarch64-registered-target to files where it was missed
- Added overloaded forms to bfloat tests
clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2_bfloat.cpp | ||
---|---|---|
9 | I've done this how I think it makes sense, which is to have the flags +sve +bf16 in the overload run line, but let me know if this doesn't seem correct to you. |
(see my commen later on as well) I'd remove this target feature and move those BF16 tests to a different file.