Details
- Reviewers
Mordante ldionne var-const - Group Reviewers
Restricted Project - Commits
- rG4262b523ff16: [libc++][NFC] Enable modernize-use-override
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Nice improvement! Looking at the UBSAN CI failures there are more overrides to be added.
Can you add an NFC to the title of the patch?
libcxx/include/__memory/shared_ptr.h | ||
---|---|---|
134 | Just curious did you use -fix for clang-tidy? | |
libcxx/include/codecvt | ||
226–238 | Did the indention change? | |
262–273 | Did the indention change? | |
297–308 | Did the indention change? | |
331–342 | Did the indention change? | |
365–376 | Did the indention change? | |
399–410 | Did the indention change? Please also validate similar changes. |
- Try to fix CI
libcxx/include/__memory/shared_ptr.h | ||
---|---|---|
134 | Kind-of. I went trough the errors and let my IDE auto-fix them. Using -fix doesn't work very well because we copy the headers around. | |
libcxx/include/codecvt | ||
226–238 | The return type also doesn't have it's own line anymore. That's why the diff looks so weird. | |
262–273 | It changed the same as the last one. | |
297–308 | Same | |
331–342 | same | |
365–376 | same | |
399–410 | same |
Just curious did you use -fix for clang-tidy?