Differential D124620

[WIP][libc++][format] DO NOT REVIEW
Needs ReviewPublic
Actions

Authored by Mordante on Apr 28 2022, 8:37 AM.

Tags

Subscribers

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Contains a new approach of std::format's parser and formatters. This
approach saves over 10KB of the binary size.

This patch is still work-in-progress. This review is to test the CI.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	7,950 ms	libcxx CI MinGW (DLL) > llvm-libc++-mingw-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 13'; clang-tidy --version
	7,680 ms	libcxx CI MinGW (Static) > llvm-libc++-mingw-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 13'; clang-tidy --version

Event Timeline

Mordante created this revision.Apr 28 2022, 8:37 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 8:37 AM

Herald added a subscriber: mgorny. · View Herald Transcript

Mordante requested review of this revision.Apr 28 2022, 8:37 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 8:37 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Trigger CI.

Fixes linting issues.

Clang-tidy fixes.

Harbormaster completed remote builds in B161822: Diff 425821.Apr 28 2022, 10:18 AM

More CI fixes.

Harbormaster completed remote builds in B161841: Diff 425845.Apr 28 2022, 1:00 PM

Attempt to fix several CI issues.

Harbormaster completed remote builds in B162094: Diff 426214.Apr 30 2022, 5:59 AM

Add some debug information.

Harbormaster completed remote builds in B162100: Diff 426222.Apr 30 2022, 8:39 AM

More CI fixes.

Harbormaster completed remote builds in B162254: Diff 426418.May 2 2022, 9:25 AM

Attempt more CI fixes.

Harbormaster completed remote builds in B162267: Diff 426435.May 2 2022, 10:13 AM

Fixes copy-paste error.

Harbormaster completed remote builds in B162275: Diff 426449.May 2 2022, 11:48 AM

Refactor and polish.

Fix CI error.

Harbormaster completed remote builds in B162836: Diff 427205.May 5 2022, 1:35 AM

Mordante mentioned this in D125606: [libc++][format] Improve string formatters.May 14 2022, 6:04 AM

Mordante mentioned this in rG77ad77c0710f: [libc++][format] Improve string formatters.Jun 21 2022, 10:40 PM

Revision Contents
Changeset List

Path

Size

libcxx/

benchmarks/

std_format_spec_string_unicode.bench.cpp

58 lines

include/

3 lines

__format/

2 lines

9 lines

269 lines

formatter_bool.h

108 lines

formatter_char.h

70 lines

formatter_floating_point.h

399 lines

formatter_integer.h

130 lines

formatter_integral.h

587 lines

formatter_output.h

362 lines

formatter_pointer.h

57 lines

formatter_string.h

119 lines

476 lines

parser_std_format_spec.h

719 lines

parser_std_format_spec_v2.h

594 lines

3 lines

module.modulemap

3 lines

test/

libcxx/

clang_tidy.sh.cpp

2 lines

private_headers.verify.cpp

3 lines

utilities/

format/

format.string/

format.string.std/

concepts_precision.h

std_format_spec_bool.pass.cpp

std_format_spec_char.pass.cpp

std_format_spec_floating_point.pass.cpp

std_format_spec_integer.pass.cpp

std_format_spec_parser.pass.cpp

533 lines

std_format_spec_pointer.pass.cpp

std_format_spec_string.pass.cpp

std_format_spec_string_non_unicode.pass.cpp

17 lines

std_format_spec_string_unicode.pass.cpp

9 lines

std/

utilities/

format/

format.formatter/

format.context/

types.compile.pass.cpp

131 lines

format.functions/

1 line

Diff 426449

libcxx/benchmarks/std_format_spec_string_unicode.bench.cpp

Loading...

libcxx/include/CMakeLists.txt

Loading...

libcxx/include/__format/buffer.h

Loading...

libcxx/include/__format/format_fwd.h

Loading...

libcxx/include/__format/formatter.h

Loading...

libcxx/include/__format/formatter_bool.h

Loading...

libcxx/include/__format/formatter_char.h

Loading...

libcxx/include/__format/formatter_floating_point.h

Loading...

libcxx/include/__format/formatter_integer.h

Loading...

libcxx/include/__format/formatter_integral.h

Loading...

libcxx/include/__format/formatter_output.h

Loading...

libcxx/include/__format/formatter_pointer.h

Loading...

libcxx/include/__format/formatter_string.h

Loading...

libcxx/include/__format/formatter_v2.h

Loading...

libcxx/include/__format/parser_std_format_spec.h

Loading...

libcxx/include/__format/parser_std_format_spec_v2.h

Loading...

libcxx/include/format

Loading...

libcxx/include/module.modulemap

Loading...

libcxx/test/libcxx/clang_tidy.sh.cpp

Loading...

libcxx/test/libcxx/private_headers.verify.cpp

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/concepts_precision.h

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_bool.pass.cpp

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_char.pass.cpp

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_floating_point.pass.cpp

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_integer.pass.cpp

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_parser.pass.cpp

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_pointer.pass.cpp

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string.pass.cpp

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string_non_unicode.pass.cpp

Loading...

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string_unicode.pass.cpp

Loading...

libcxx/test/std/utilities/format/format.formatter/format.context/types.compile.pass.cpp

Loading...

libcxx/test/std/utilities/format/format.functions/format_tests.h

Loading...