Page MenuHomePhabricator
Differential D124620

[WIP][libc++][format] DO NOT REVIEW
Needs ReviewPublic
Actions

Authored by Mordante on Apr 28 2022, 8:37 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Contains a new approach of std::format's parser and formatters. This
approach saves over 10KB of the binary size.

This patch is still work-in-progress. This review is to test the CI.

Diff Detail

Unit TestsFailed
View All

TimeTest
27,350 mslibcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.libcxx/utilities/format/format_string/format_string_std::std_format_spec_string_unicode.pass.cpp
Script: -- : 'COMPILED WITH'; /opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r /scratch/powerllvm/cpap8008/llvm-project/libcxx-ci/libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string_unicode.pass.cpp --target=powerpc-ibm-aix -nostdinc++ -D__LIBC_NO_CPP_MATH_OVERLOADS__ -I /scratch/powerllvm/cpap8008/llvm-project/libcxx-ci/build/aix/include/c++/v1 -I /scratch/powerllvm/cpap8008/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /scratch/powerllvm/cpap8008/llvm-project/libcxx-ci/build/aix/lib -lc++ -lc++abi -latomic -Wl,-bbigtoc -o /scratch/powerllvm/cpap8008/llvm-project/libcxx-ci/build/aix/test/libcxx/utilities/format/format.string/format.string.std/Output/std_format_spec_string_unicode.pass.cpp.dir/t.tmp.exe
2,370 mslibcxx CI Assertions enabled > llvm-libc++-shared-cfg-in.libcxx/utilities/format/format_string/format_string_std::std_format_spec_parser.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/c++ /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_parser.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-assertions/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-assertions/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_ASSERTIONS=1 -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-assertions/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-assertions/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-assertions/test/libcxx/utilities/format/format.string/format.string.std/Output/std_format_spec_parser.pass.cpp.dir/t.tmp.exe
2,660 mslibcxx CI Debug iterators > llvm-libc++-shared-cfg-in.libcxx/utilities/format/format_string/format_string_std::std_format_spec_parser.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/c++ /home/libcxx-builder/.buildkite-agent/builds/db5894f107fc-1/llvm-project/libcxx-ci/libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_parser.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/db5894f107fc-1/llvm-project/libcxx-ci/build/generic-debug-iterators/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/db5894f107fc-1/llvm-project/libcxx-ci/build/generic-debug-iterators/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/db5894f107fc-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Wno-macro-redefined -D_LIBCPP_DEBUG=1 -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/db5894f107fc-1/llvm-project/libcxx-ci/build/generic-debug-iterators/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/db5894f107fc-1/llvm-project/libcxx-ci/build/generic-debug-iterators/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/db5894f107fc-1/llvm-project/libcxx-ci/build/generic-debug-iterators/test/libcxx/utilities/format/format.string/format.string.std/Output/std_format_spec_parser.pass.cpp.dir/t.tmp.exe
1,920 mslibcxx CI GCC 11 / C++11 > llvm-libc++-shared-gcc-cfg-in.libcxx::double_include.sh.cpp
Script: -- : 'RUN: at line 11'; /usr/bin/g++-11 -c /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/libcxx/test/libcxx/double_include.sh.cpp -o /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-gcc-cxx11/test/libcxx/Output/double_include.sh.cpp.dir/t.tmp.first.o -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-gcc-cxx11/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-gcc-cxx11/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++11 -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-aligned-allocation-unavailable -Wno-atomic-alignment -Wno-sized-deallocation -Wno-literal-suffix -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_DISABLE_AVAILABILITY -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS -Wno-placement-new -Wno-class-memaccess
1,920 mslibcxx CI GCC 11 / C++11 > llvm-libc++-shared-gcc-cfg-in.libcxx::min_max_macros.compile.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/g++-11 /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/libcxx/test/libcxx/min_max_macros.compile.pass.cpp -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-gcc-cxx11/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/build/generic-gcc-cxx11/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/0dd3bc0cc837-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++11 -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-aligned-allocation-unavailable -Wno-atomic-alignment -Wno-sized-deallocation -Wno-literal-suffix -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_DISABLE_AVAILABILITY -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS -Wno-placement-new -Wno-class-memaccess -fsyntax-only
View Full Test Results (14 Failed)

Event Timeline

Mordante created this revision.Apr 28 2022, 8:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 8:37 AM
Herald added a subscriber: mgorny. · View Herald Transcript
Mordante requested review of this revision.Apr 28 2022, 8:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 8:37 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante updated this revision to Diff 425803.Apr 28 2022, 8:46 AM

Trigger CI.

Mordante updated this revision to Diff 425811.Apr 28 2022, 9:09 AM

Fixes linting issues.

Mordante updated this revision to Diff 425821.Apr 28 2022, 9:49 AM

Clang-tidy fixes.

Harbormaster completed remote builds in B161822: Diff 425821.Apr 28 2022, 10:18 AM
Mordante updated this revision to Diff 425845.Apr 28 2022, 10:42 AM

More CI fixes.

Harbormaster completed remote builds in B161841: Diff 425845.Apr 28 2022, 1:00 PM
Mordante updated this revision to Diff 426214.Apr 30 2022, 3:37 AM

Attempt to fix several CI issues.

Harbormaster completed remote builds in B162094: Diff 426214.Apr 30 2022, 5:59 AM
Mordante updated this revision to Diff 426222.Apr 30 2022, 6:20 AM

Add some debug information.

Harbormaster completed remote builds in B162100: Diff 426222.Apr 30 2022, 8:39 AM
Mordante updated this revision to Diff 426418.May 2 2022, 8:25 AM

More CI fixes.

Harbormaster completed remote builds in B162254: Diff 426418.May 2 2022, 9:25 AM
Mordante updated this revision to Diff 426435.May 2 2022, 9:38 AM

Attempt more CI fixes.

Harbormaster completed remote builds in B162267: Diff 426435.May 2 2022, 10:13 AM
Mordante updated this revision to Diff 426449.May 2 2022, 10:37 AM

Fixes copy-paste error.

Harbormaster completed remote builds in B162275: Diff 426449.May 2 2022, 11:48 AM
Mordante updated this revision to Diff 427198.May 4 2022, 10:47 PM

Refactor and polish.

Mordante updated this revision to Diff 427205.May 4 2022, 11:19 PM

Fix CI error.

Harbormaster completed remote builds in B162836: Diff 427205.May 5 2022, 1:35 AM
Mordante mentioned this in D125606: [libc++][format] Improve string formatters.May 14 2022, 6:04 AM
Mordante mentioned this in rG77ad77c0710f: [libc++][format] Improve string formatters.Jun 21 2022, 10:40 PM

Revision Contents
Changeset List

Diff 425845

View Options

libcxx/include/CMakeLists.txt

Loading...
View Options

libcxx/include/__format/buffer.h

Loading...
View Options

libcxx/include/__format/format_arg.h

Loading...
View Options

libcxx/include/__format/format_fwd.h

Loading...
View Options

libcxx/include/__format/format_string.h

Loading...
View Options

libcxx/include/__format/formatter.h

Loading...
View Options

libcxx/include/__format/formatter_bool.h

Loading...
View Options

libcxx/include/__format/formatter_char.h

Loading...
View Options

libcxx/include/__format/formatter_floating_point.h

Loading...
View Options

libcxx/include/__format/formatter_integer.h

Loading...
View Options

libcxx/include/__format/formatter_integral.h

Loading...
View Options

libcxx/include/__format/formatter_output.h

Loading...
View Options

libcxx/include/__format/formatter_pointer.h

Loading...
View Options

libcxx/include/__format/formatter_string.h

Loading...
View Options

libcxx/include/__format/formatter_v2.h

Loading...
View Options

libcxx/include/__format/parser_std_format_spec.h

Loading...
View Options

libcxx/include/__format/parser_std_format_spec_v2.h

Loading...
View Options

libcxx/include/format

Loading...
View Options

libcxx/include/module.modulemap

Loading...
View Options

libcxx/test/libcxx/private_headers.verify.cpp

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/concepts_precision.h

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_bool.pass.cpp

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_char.pass.cpp

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_floating_point.pass.cpp

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_integer.pass.cpp

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_parser.pass.cpp

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_pointer.pass.cpp

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string.pass.cpp

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string_non_unicode.pass.cpp

Loading...
View Options

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string_unicode.pass.cpp

Loading...
View Options

libcxx/test/std/utilities/format/format.formatter/format.context/types.compile.pass.cpp

Loading...
View Options

libcxx/test/std/utilities/format/format.functions/format_tests.h

Loading...