This is an archive of the discontinued LLVM Phabricator instance.

Differential D124491

OpenMP: mark allocptr attribute on __kmpc_free_shared
ClosedPublic

Authored by durin42 on Apr 26 2022, 5:34 PM.

Details

Reviewers
jdoerfert
Commits
rG4fea8ee540aa: OpenMP: mark allocptr attribute on __kmpc_free_shared

Diff Detail

Unit TestsFailed

TimeTest
60,100 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp

Event Timeline

durin42 created this revision.Apr 26 2022, 5:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 5:34 PM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
durin42 requested review of this revision.Apr 26 2022, 5:34 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptApr 26 2022, 5:34 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, sstefan1. · View Herald Transcript
durin42 mentioned this in D123084: BuildLibCalls: infer allocptr attribute for free and realloc() family functions.Apr 26 2022, 5:35 PM
durin42 added a child revision: D123086: BuildLibCalls: add alloc-family attribute to many allocator functions.
Harbormaster completed remote builds in B161497: Diff 425361.Apr 26 2022, 7:29 PM
durin42 updated this revision to Diff 425836.Apr 28 2022, 10:34 AM
durin42 edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B161833: Diff 425836.Apr 28 2022, 11:44 AM
durin42 removed a child revision: D123086: BuildLibCalls: add alloc-family attribute to many allocator functions.May 2 2022, 7:03 AM
durin42 updated this revision to Diff 426413.May 2 2022, 7:07 AM
durin42 updated this revision to Diff 444058.Jul 12 2022, 1:10 PM
durin42 added a comment.Jul 12 2022, 1:10 PM

I've rebased this, and think it's probably still relevant.

Harbormaster completed remote builds in B174961: Diff 444058.Jul 12 2022, 3:25 PM
jdoerfert accepted this revision.Sep 7 2022, 10:18 AM

LG

This revision is now accepted and ready to land.Sep 7 2022, 10:18 AM
This revision was landed with ongoing or failed builds.Sep 9 2022, 11:10 AM
Closed by commit rG4fea8ee540aa: OpenMP: mark allocptr attribute on __kmpc_free_shared (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.
durin42 added a commit: rG4fea8ee540aa: OpenMP: mark allocptr attribute on __kmpc_free_shared.

Revision Contents

PathSize
llvm/
include/
llvm/
Frontend/
OpenMP/
7 lines
test/
Transforms/
OpenMP/
2 lines

Diff 444058

llvm/include/llvm/Frontend/OpenMP/OMPKinds.def

Show First 20 Lines • Show All 527 Lines • ▼ Show 20 Lines
__OMP_ATTRS_SET(InaccessibleArgOnlyAttrs, __OMP_ATTRS_SET(InaccessibleArgOnlyAttrs,
OptimisticAttributes OptimisticAttributes
? AttributeSet(EnumAttr(NoUnwind), EnumAttr(NoSync), ? AttributeSet(EnumAttr(NoUnwind), EnumAttr(NoSync),
EnumAttr(InaccessibleMemOrArgMemOnly), EnumAttr(InaccessibleMemOrArgMemOnly),
EnumAttr(WillReturn), EnumAttr(NoFree)) EnumAttr(WillReturn), EnumAttr(NoFree))
: AttributeSet(EnumAttr(NoUnwind))) : AttributeSet(EnumAttr(NoUnwind)))
__OMP_ATTRS_SET(NoCaptureAttrs,
OptimisticAttributes
? AttributeSet(EnumAttr(NoCapture))
: AttributeSet(EnumAttr(NoCapture)))
__OMP_ATTRS_SET(AlwaysInlineAttrs, __OMP_ATTRS_SET(AlwaysInlineAttrs,
OptimisticAttributes OptimisticAttributes
? AttributeSet(EnumAttr(AlwaysInline)) ? AttributeSet(EnumAttr(AlwaysInline))
: AttributeSet(EnumAttr(AlwaysInline))) : AttributeSet(EnumAttr(AlwaysInline)))
#if 0 #if 0
__OMP_ATTRS_SET(InaccessibleOnlyAttrs, __OMP_ATTRS_SET(InaccessibleOnlyAttrs,
OptimisticAttributes OptimisticAttributes
▲ Show 20 Lines • Show All 368 Lines • ▼ Show 20 Lines
__OMP_RTL_ATTRS(__kmpc_doacross_fini, BarrierAttrs, AttributeSet(), __OMP_RTL_ATTRS(__kmpc_doacross_fini, BarrierAttrs, AttributeSet(),
ParamAttrs(ReadOnlyPtrAttrs)) ParamAttrs(ReadOnlyPtrAttrs))
__OMP_RTL_ATTRS(__kmpc_alloc_shared, AttributeSet( __OMP_RTL_ATTRS(__kmpc_alloc_shared, AttributeSet(
EnumAttr(NoUnwind), EnumAttr(NoUnwind),
EnumAttr(NoSync), EnumAttr(NoSync),
AllocSizeAttr(0, None)), ReturnPtrAttrs, ParamAttrs()) AllocSizeAttr(0, None)), ReturnPtrAttrs, ParamAttrs())
__OMP_RTL_ATTRS(__kmpc_free_shared, DeviceAllocAttrs, AttributeSet(), __OMP_RTL_ATTRS(__kmpc_free_shared, DeviceAllocAttrs, AttributeSet(),
ParamAttrs(NoCaptureAttrs)) ParamAttrs(AttributeSet(EnumAttr(NoCapture), EnumAttr(AllocatedPointer))))
__OMP_RTL_ATTRS(__kmpc_alloc, DefaultAttrs, ReturnPtrAttrs, ParamAttrs()) __OMP_RTL_ATTRS(__kmpc_alloc, DefaultAttrs, ReturnPtrAttrs, ParamAttrs())
__OMP_RTL_ATTRS(__kmpc_aligned_alloc, DefaultAttrs, ReturnPtrAttrs, __OMP_RTL_ATTRS(__kmpc_aligned_alloc, DefaultAttrs, ReturnPtrAttrs,
ParamAttrs()) ParamAttrs())
__OMP_RTL_ATTRS(__kmpc_free, AllocAttrs, AttributeSet(), ParamAttrs()) __OMP_RTL_ATTRS(__kmpc_free, AllocAttrs, AttributeSet(), ParamAttrs())
__OMP_RTL_ATTRS(__kmpc_init_allocator, DefaultAttrs, ReturnPtrAttrs, __OMP_RTL_ATTRS(__kmpc_init_allocator, DefaultAttrs, ReturnPtrAttrs,
ParamAttrs()) ParamAttrs())
▲ Show 20 Lines • Show All 323 Lines • Show Last 20 Lines

llvm/test/Transforms/OpenMP/remove_globalization.ll

Show First 20 Lines • Show All 149 Lines • ▼ Show 20 Linesentry:
call void @use(i8* %0) call void @use(i8* %0)
call void @__kmpc_free_shared(i8* %0, i64 4) call void @__kmpc_free_shared(i8* %0, i64 4)
ret void ret void
} }
; CHECK: declare i8* @__kmpc_alloc_shared(i64) ; CHECK: declare i8* @__kmpc_alloc_shared(i64)
declare i8* @__kmpc_alloc_shared(i64) declare i8* @__kmpc_alloc_shared(i64)
; CHECK: declare void @__kmpc_free_shared(i8* nocapture, i64) ; CHECK: declare void @__kmpc_free_shared(i8* allocptr nocapture, i64)
declare void @__kmpc_free_shared(i8*, i64) declare void @__kmpc_free_shared(i8*, i64)
declare void @unknown_no_openmp() "llvm.assume"="omp_no_openmp" declare void @unknown_no_openmp() "llvm.assume"="omp_no_openmp"
!llvm.dbg.cu = !{!0} !llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!3, !4, !6, !7} !llvm.module.flags = !{!3, !4, !6, !7}
!nvvm.annotations = !{!5} !nvvm.annotations = !{!5}
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines