This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Cleanup miscellaneous header items
ClosedPublic

Authored by wristow on Apr 26 2022, 11:30 AM.

Details

Summary
  • Explain the use of the _MM_SHUFFLE and _MM_SHUFFLE2 macros
  • Update some doxygen parameter descriptions to match the implementations
  • Add "see also" doxygen tags to some intrinsics
  • Minor clang-format changes

Diff Detail

Event Timeline

wristow created this revision.Apr 26 2022, 11:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 11:30 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
wristow requested review of this revision.Apr 26 2022, 11:30 AM
RKSimon accepted this revision.Apr 26 2022, 1:54 PM

LGTM

clang/lib/Headers/__wmmintrin_pclmul.h
25

Its annoying that we've never gotten https://github.com/llvm/llvm-project/issues/35297 fixed to have helped with these param name mismatches....

This revision is now accepted and ready to land.Apr 26 2022, 1:54 PM
This revision was landed with ongoing or failed builds.Apr 26 2022, 2:38 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 2:38 PM

Thanks for the review @RKSimon !

clang/lib/Headers/__wmmintrin_pclmul.h
25

Yes -- would be nice to catch these sorts of things.