This is an archive of the discontinued LLVM Phabricator instance.

Differential D124371

[libunwind] Fix build warnings in Unwind-EHABI.cpp. NFC.
ClosedPublic

Authored by mstorsjo on Apr 25 2022, 3:35 AM.

Details

Reviewers
MaskRay
DavidSpickett
ldionne
Group Reviewers
Restricted Project
Commits
rGc98d9502fc6b: [libunwind] Fix build warnings in Unwind-EHABI.cpp. NFC.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 25 2022, 3:35 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 25 2022, 3:35 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: StephenFan. · View Herald Transcript
mstorsjo requested review of this revision.Apr 25 2022, 3:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2022, 3:35 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
DavidSpickett accepted this revision.Apr 25 2022, 3:46 AM

LGTM

Harbormaster completed remote builds in B161127: Diff 424856.Apr 25 2022, 4:46 AM
mstorsjo mentioned this in D124375: [runtimes] [cmake] Fix -Werror detection in common build configs.Apr 25 2022, 7:04 AM
ldionne accepted this revision.Apr 25 2022, 8:54 AM
This revision is now accepted and ready to land.Apr 25 2022, 8:54 AM
Closed by commit rGc98d9502fc6b: [libunwind] Fix build warnings in Unwind-EHABI.cpp. NFC. (authored by mstorsjo). · Explain WhyApr 25 2022, 1:01 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGc98d9502fc6b: [libunwind] Fix build warnings in Unwind-EHABI.cpp. NFC..

Revision Contents

PathSize
libunwind/
src/
3 lines

Diff 425005

libunwind/src/Unwind-EHABI.cpp

Show First 20 Lines • Show All 430 Lines • ▼ Show 20 Lines#ifdef __ARM_FEATURE_PAUTH
if (hasReturnAddrAuthCode) { if (hasReturnAddrAuthCode) {
uint32_t sp; uint32_t sp;
uint32_t pac; uint32_t pac;
_Unwind_VRS_Get(context, _UVRSC_CORE, UNW_ARM_SP, _UVRSD_UINT32, &sp); _Unwind_VRS_Get(context, _UVRSC_CORE, UNW_ARM_SP, _UVRSD_UINT32, &sp);
_Unwind_VRS_Get(context, _UVRSC_PSEUDO, UNW_ARM_RA_AUTH_CODE, _Unwind_VRS_Get(context, _UVRSC_PSEUDO, UNW_ARM_RA_AUTH_CODE,
_UVRSD_UINT32, &pac); _UVRSD_UINT32, &pac);
__asm__ __volatile__("autg %0, %1, %2" : : "r"(pac), "r"(lr), "r"(sp) :); __asm__ __volatile__("autg %0, %1, %2" : : "r"(pac), "r"(lr), "r"(sp) :);
} }
#else
(void)hasReturnAddrAuthCode;
#endif #endif
_Unwind_VRS_Set(context, _UVRSC_CORE, UNW_ARM_IP, _UVRSD_UINT32, &lr); _Unwind_VRS_Set(context, _UVRSC_CORE, UNW_ARM_IP, _UVRSD_UINT32, &lr);
} }
return _URC_CONTINUE_UNWIND; return _URC_CONTINUE_UNWIND;
} }
extern "C" _LIBUNWIND_EXPORT _Unwind_Reason_Code extern "C" _LIBUNWIND_EXPORT _Unwind_Reason_Code
__aeabi_unwind_cpp_pr0(_Unwind_State state, _Unwind_Control_Block *ucbp, __aeabi_unwind_cpp_pr0(_Unwind_State state, _Unwind_Control_Block *ucbp,
▲ Show 20 Lines • Show All 741 Lines • ▼ Show 20 Lines_Unwind_DeleteException(_Unwind_Exception *exception_object) {
if (exception_object->exception_cleanup != NULL) if (exception_object->exception_cleanup != NULL)
(*exception_object->exception_cleanup)(_URC_FOREIGN_EXCEPTION_CAUGHT, (*exception_object->exception_cleanup)(_URC_FOREIGN_EXCEPTION_CAUGHT,
exception_object); exception_object);
} }
extern "C" _LIBUNWIND_EXPORT _Unwind_Reason_Code extern "C" _LIBUNWIND_EXPORT _Unwind_Reason_Code
__gnu_unwind_frame(_Unwind_Exception *exception_object, __gnu_unwind_frame(_Unwind_Exception *exception_object,
struct _Unwind_Context *context) { struct _Unwind_Context *context) {
(void)exception_object;
unw_cursor_t *cursor = (unw_cursor_t *)context; unw_cursor_t *cursor = (unw_cursor_t *)context;
switch (__unw_step(cursor)) { switch (__unw_step(cursor)) {
case UNW_STEP_SUCCESS: case UNW_STEP_SUCCESS:
return _URC_OK; return _URC_OK;
case UNW_STEP_END: case UNW_STEP_END:
return _URC_END_OF_STACK; return _URC_END_OF_STACK;
default: default:
return _URC_FAILURE; return _URC_FAILURE;
} }
} }
#endif // defined(_LIBUNWIND_ARM_EHABI) #endif // defined(_LIBUNWIND_ARM_EHABI)