This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Add SystemZ support
ClosedPublic

Authored by uweigand on Apr 22 2022, 4:35 AM.

Details

Reviewers
ldionne
MaskRay
Group Reviewers
Restricted Project
Commits
rG364c5023d2ce: [libunwind] Add SystemZ support
Summary

This adds support for the SystemZ (s390x) architecture to libunwind.

Support should be complete with the exception of unwinding from signal handlers. That will require additional code along the lines of what Arm does, which I'm planning to submit separately.

Diff Detail

Event Timeline

uweigand created this revision.Apr 22 2022, 4:35 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 22 2022, 4:35 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
uweigand requested review of this revision.Apr 22 2022, 4:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2022, 4:35 AM
MaskRay added inline comments.
libunwind/src/Registers.hpp
4749

Either align the comments or not align at all.

uweigand updated this revision to Diff 426075.Apr 29 2022, 8:56 AM

Address coding style comment.

uweigand marked an inline comment as done.Apr 29 2022, 8:57 AM
MaskRay accepted this revision.Apr 29 2022, 12:29 PM

LGTM.

This revision is now accepted and ready to land.Apr 29 2022, 12:29 PM
This revision was landed with ongoing or failed builds.May 2 2022, 5:38 AM
This revision was automatically updated to reflect the committed changes.