This is an archive of the discontinued LLVM Phabricator instance.

Differential D124200

[Libomptarget][remote] Add OpenMP linker flag to the plugin
ClosedPublic

Authored by atmnpatel on Apr 21 2022, 12:43 PM.

Details

Reviewers
jdoerfert
Commits
rGc44420e90d80: [Libomptarget][remote] Add OpenMP linker flag to the plugin
Summary

The remote offloading server and plugin rely on OpenMP, so this needs to be added as a linker flag. Without this, applications segfault.

Diff Detail

Event Timeline

atmnpatel created this revision.Apr 21 2022, 12:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 12:43 PM
Herald added subscribers: guansong, yaxunl, mgorny. · View Herald Transcript
atmnpatel requested review of this revision.Apr 21 2022, 12:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 12:43 PM
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
jdoerfert accepted this revision.Apr 21 2022, 12:44 PM

LG

This revision is now accepted and ready to land.Apr 21 2022, 12:44 PM
This revision was landed with ongoing or failed builds.Apr 21 2022, 12:45 PM
Closed by commit rGc44420e90d80: [Libomptarget][remote] Add OpenMP linker flag to the plugin (authored by adpatel6). · Explain Why
This revision was automatically updated to reflect the committed changes.
adpatel6 added a commit: rGc44420e90d80: [Libomptarget][remote] Add OpenMP linker flag to the plugin.
Harbormaster completed remote builds in B160706: Diff 424270.Apr 21 2022, 12:52 PM

Revision Contents

PathSize
openmp/
libomptarget/
plugins/
remote/
server/
1 line
src/
1 line

Diff 424270

openmp/libomptarget/plugins/remote/server/CMakeLists.txt

Show All 22 Linesadd_executable(openmp-offloading-server
OffloadingServer.cpp OffloadingServer.cpp
) )
target_link_libraries(openmp-offloading-server target_link_libraries(openmp-offloading-server
grpc++ grpc++
protobuf protobuf
absl::synchronization absl::synchronization
${OPENMP_PTHREAD_LIB} ${OPENMP_PTHREAD_LIB}
omp
"-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/../../exports") "-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/../../exports")

openmp/libomptarget/plugins/remote/src/CMakeLists.txt

Show All 30 Lines
# Install plugin under the lib destination folder. # Install plugin under the lib destination folder.
install(TARGETS omptarget.rtl.rpc LIBRARY DESTINATION "${OPENMP_INSTALL_LIBDIR}") install(TARGETS omptarget.rtl.rpc LIBRARY DESTINATION "${OPENMP_INSTALL_LIBDIR}")
target_link_libraries(omptarget.rtl.rpc target_link_libraries(omptarget.rtl.rpc
grpc++ grpc++
protobuf protobuf
absl::synchronization absl::synchronization
${OPENMP_PTHREAD_LIB} ${OPENMP_PTHREAD_LIB}
omp
"-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/../../exports") "-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/../../exports")
# Report to the parent scope that we are building a plugin for RPC. # Report to the parent scope that we are building a plugin for RPC.
set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS} rpc" PARENT_SCOPE) set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS} rpc" PARENT_SCOPE)