This is an archive of the discontinued LLVM Phabricator instance.

Differential D124157

[clang][preprocessor] Add more macros to target AVR
ClosedPublic

Authored by benshi001 on Apr 21 2022, 2:43 AM.

Details

Reviewers
aykevl
dylanmckay
MaskRay
Commits
rG42fa5bae7afc: [clang][preprocessor] Add more macros to target AVR

Diff Detail

Event Timeline

benshi001 created this revision.Apr 21 2022, 2:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 2:43 AM
Herald added a subscriber: Jim. · View Herald Transcript
benshi001 requested review of this revision.Apr 21 2022, 2:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 2:43 AM
Herald added subscribers: cfe-commits, jacquesguan. · View Herald Transcript
Harbormaster completed remote builds in B160612: Diff 424133.Apr 21 2022, 3:37 AM
benshi001 updated this revision to Diff 424355.Apr 21 2022, 7:09 PM
benshi001 added a reviewer: MaskRay.May 1 2022, 7:30 PM

avr-gcc does define this __AVR_TINY_ macro for the tiny device family, we can check that by avr-gcc -mmcu=avrtiny -E -dM -xc /dev/null -dM | grep tiny -i.

Herald added a subscriber: StephenFan. · View Herald TranscriptMay 1 2022, 7:30 PM
MaskRay accepted this revision.May 1 2022, 8:19 PM
This revision is now accepted and ready to land.May 1 2022, 8:19 PM
This revision was landed with ongoing or failed builds.May 1 2022, 9:39 PM
Closed by commit rG42fa5bae7afc: [clang][preprocessor] Add more macros to target AVR (authored by benshi001). · Explain Why
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rG42fa5bae7afc: [clang][preprocessor] Add more macros to target AVR.

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
3 lines
test/
Preprocessor/
7 lines

Diff 426329

clang/lib/Basic/Targets/AVR.cpp

Show First 20 Lines • Show All 378 Lines • ▼ Show 20 Linesvoid AVRTargetInfo::getTargetDefines(const LangOptions &Opts,
Builder.defineMacro("__AVR"); Builder.defineMacro("__AVR");
Builder.defineMacro("__AVR__"); Builder.defineMacro("__AVR__");
Builder.defineMacro("__ELF__"); Builder.defineMacro("__ELF__");
if (!this->CPU.empty()) { if (!this->CPU.empty()) {
auto It = llvm::find_if( auto It = llvm::find_if(
AVRMcus, [&](const MCUInfo &Info) { return Info.Name == this->CPU; }); AVRMcus, [&](const MCUInfo &Info) { return Info.Name == this->CPU; });
if (It->IsTiny)
Builder.defineMacro("__AVR_TINY__", "1");
if (It != std::end(AVRMcus)) { if (It != std::end(AVRMcus)) {
Builder.defineMacro(It->DefineName); Builder.defineMacro(It->DefineName);
if (It->NumFlashBanks >= 1) if (It->NumFlashBanks >= 1)
Builder.defineMacro("__flash", "__attribute__((address_space(1)))"); Builder.defineMacro("__flash", "__attribute__((address_space(1)))");
if (It->NumFlashBanks >= 2) if (It->NumFlashBanks >= 2)
Builder.defineMacro("__flash1", "__attribute__((address_space(2)))"); Builder.defineMacro("__flash1", "__attribute__((address_space(2)))");
if (It->NumFlashBanks >= 3) if (It->NumFlashBanks >= 3)
Builder.defineMacro("__flash2", "__attribute__((address_space(3)))"); Builder.defineMacro("__flash2", "__attribute__((address_space(3)))");
Show All 9 Lines

clang/test/Preprocessor/avr-common.c

// RUN: %clang_cc1 -E -dM -triple avr-unknown-unknown /dev/null | FileCheck -match-full-lines %s // RUN: %clang_cc1 -E -dM -triple avr-unknown-unknown -target-cpu attiny13 /dev/null | FileCheck -match-full-lines --check-prefixes=CHECK,AVR %s
// RUN: %clang_cc1 -E -dM -triple avr-unknown-unknown -target-cpu attiny4 /dev/null | FileCheck -match-full-lines --check-prefixes=CHECK,TINY %s
// CHECK: #define AVR 1 // CHECK: #define AVR 1
// CHECK: #define __AVR 1 // CHECK: #define __AVR 1
// TINY: #define __AVR_TINY__ 1
// AVR-NOT: __AVR_TINY__
// CHECK: #define __AVR__ 1 // CHECK: #define __AVR__ 1
// CHECK: #define __ELF__ 1 // CHECK: #define __ELF__ 1