This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Always pass namedsects option when linking with PGO.
ClosedPublic

Authored by w2yehia on Apr 19 2022, 3:16 PM.

Details

Summary

Currently, we only pass the -bdbg:namedsects linker option when PGO is ON and LTO is OFF. That's because LTO does the merging of multiple sections of the same name into a single section, and so we don't need the linker option.
However, the input object files at link step could be a mix of LTO and non-LTO built objects, and so we should always specify the -bdbg:namedsects option when linking with PGO.

Diff Detail

Event Timeline

w2yehia created this revision.Apr 19 2022, 3:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2022, 3:16 PM
Herald added a subscriber: wenlei. · View Herald Transcript
w2yehia requested review of this revision.Apr 19 2022, 3:16 PM
w2yehia updated this revision to Diff 423756.Apr 19 2022, 3:49 PM
jsji accepted this revision.Apr 21 2022, 5:38 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Apr 21 2022, 5:38 AM
This revision was landed with ongoing or failed builds.Apr 21 2022, 10:02 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 10:02 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript