[lit][libcxx] Forward sanitizer environment

[philnik]

What do you want to achieve with this change?

[vitalybuka]

In D123843#3453580, @philnik wrote:

What do you want to achieve with this change?

I want to be able to stuff like this:
MSAN_OPTIONS=poison_in_dtor=1 ninja check-libcxx

[philnik]

In D123843#3454223, @vitalybuka wrote:

I want to be able to stuff like this:
MSAN_OPTIONS=poison_in_dtor=1 ninja check-libcxx

I think the better option would be to add another lit configuration. Passing behaviour changing environment variables through makes the builds less reproducible, and here it seems to be quite simple to add it as a few flags.

[vitalybuka]

In D123843#3454456, @philnik wrote:

In D123843#3454223, @vitalybuka wrote:

I want to be able to stuff like this:
MSAN_OPTIONS=poison_in_dtor=1 ninja check-libcxx

I think the better option would be to add another lit configuration. Passing behaviour changing environment variables through makes the builds less reproducible, and here it seems to be quite simple to add it as a few flags.

Not sure I understand what is the proposal. Can you please clarify?

[vitalybuka]

MSAN_OPTIONS=poison_in_dtor=1 is default, so this patch is not needed

[ldionne]

[Github PR transition cleanup]

Abandoning since the author says it's not needed.

libcxx/utils/run.py

if platform.system() == 'Windows':
         # Pass some extra variables through on Windows:
         # COMSPEC is needed for running subprocesses via std::system().
         if 'COMSPEC' in os.environ:
             env['COMSPEC'] = os.environ.get('COMSPEC')
         # TEMP is needed for placing temp files in a sensible directory.
         if 'TEMP' in os.environ:
             env['TEMP'] = os.environ.get('TEMP')
 
+    pass_vars = [
+        'ASAN_SYMBOLIZER_PATH',
+        'LSAN_SYMBOLIZER_PATH',
+        'MSAN_SYMBOLIZER_PATH',
+        'TSAN_SYMBOLIZER_PATH',
+        'UBSAN_SYMBOLIZER_PATH',
+        'ASAN_OPTIONS',
+        'LSAN_OPTIONS',
+        'MSAN_OPTIONS',
+        'TSAN_OPTIONS',
+        'UBSAN_OPTIONS',
+    ]
+    for var in pass_vars:
+        val = os.environ.get(var, '')
+        if val:
+            env[var] = val
+
     # Run the command line with the given environment in the execution directory.
     return subprocess.call(commandLine, cwd=args.execdir, env=env, shell=False)
 
 
 if __name__ == '__main__':
     exit(main())