This is an archive of the discontinued LLVM Phabricator instance.

[lit] Keep stdout/stderr when using GoogleTest
AbandonedPublic

Authored by lenary on Apr 14 2022, 8:18 AM.

Details

Summary

When debugging issues with GoogleTest sharding, it is very useful to see
the stdout/stderr from the whole shard as part of the test failure
output.

This change ensures that the stream output and error code is kept and
logged in the case of any failures.

Diff Detail

Event Timeline

lenary created this revision.Apr 14 2022, 8:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2022, 8:18 AM
Herald added a subscriber: delcypher. · View Herald Transcript
lenary requested review of this revision.Apr 14 2022, 8:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2022, 8:18 AM
This revision is now accepted and ready to land.Apr 14 2022, 8:25 AM

sounds good. Could you please add a test? Probably in llvm/utils/lit/tests/googletest-format.py.

lenary abandoned this revision.Apr 25 2022, 12:34 PM

@ychen it would have been nice to give me a heads up you were going to land your own implementation. Sorry I didn’t manage to add a unit test before I went on vacation.

@ychen it would have been nice to give me a heads up you were going to land your own implementation. Sorry I didn’t manage to add a unit test before I went on vacation.

Thanks for letting me know. Sorry I have to commit it earlier since several folks reported that the missing stdout/stderr is making CI failures harder to debug and I didn't hear from you for a while ...