This is an archive of the discontinued LLVM Phabricator instance.

Clang-Repl Error Recovery Bug Fix
ClosedPublic

Authored by Purva-Chaudhari on Apr 13 2022, 5:47 AM.

Details

Summary

Currently there was re-declaration error if error was encountered in the same line (The recovery support acted only if this type of error was encountered in the first line of the program and not in subsequent lines )

Eg:

clang-repl> int i=9;
clang-repl> int j=9; err;
input_line_3:1:5: error: redefinition of 'j'
int j = 9;

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2022, 5:47 AM
Purva-Chaudhari requested review of this revision.Apr 13 2022, 5:47 AM
v.g.vassilev accepted this revision.May 28 2022, 2:47 PM

LGTM! Apologies for the delay.

This revision is now accepted and ready to land.May 28 2022, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2022, 10:00 PM

Hi,

I noticed that the testcase Interpreter/execute.cpp starts failing with this patch when run/compiled with asan:

Failed Tests (1):
  Clang :: Interpreter/execute.cpp

Seen in the buildbot run
https://lab.llvm.org/buildbot/#/builders/5/builds/24221

The run on the commit before passed:
https://lab.llvm.org/buildbot/#/builders/5/builds/24220

Hi,

I noticed that the testcase Interpreter/execute.cpp starts failing with this patch when run/compiled with asan:

Failed Tests (1):
  Clang :: Interpreter/execute.cpp

Seen in the buildbot run
https://lab.llvm.org/buildbot/#/builders/5/builds/24221

The run on the commit before passed:
https://lab.llvm.org/buildbot/#/builders/5/builds/24220

Thanks a lot for the notice @uabelho! I have reverted the patch while we are investigating.

@Purva-Chaudhari, can you take look and reproduce the asan failure locally?

Purva-Chaudhari added a comment.EditedMay 31 2022, 1:09 AM

Hi,

I noticed that the testcase Interpreter/execute.cpp starts failing with this patch when run/compiled with asan:

Failed Tests (1):
  Clang :: Interpreter/execute.cpp

Seen in the buildbot run
https://lab.llvm.org/buildbot/#/builders/5/builds/24221

The run on the commit before passed:
https://lab.llvm.org/buildbot/#/builders/5/builds/24220

Thanks a lot for the notice @uabelho! I have reverted the patch while we are investigating.

@Purva-Chaudhari, can you take look and reproduce the asan failure locally?

Trying to look into it

Fix asan test fail