Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Purva-Chaudhari (Purva Chaudhari)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2022, 9:43 PM (87 w, 2 d)

Recent Activity

Oct 3 2022

Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

check

Oct 3 2022, 3:57 AM · Restricted Project
Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

remove white space

Oct 3 2022, 1:56 AM · Restricted Project
Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

fix test and clang format

Oct 3 2022, 1:51 AM · Restricted Project

Sep 30 2022

Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

rebase, test passing locally, in build stage 1

Sep 30 2022, 12:12 AM · Restricted Project

Sep 28 2022

Purva-Chaudhari added a comment to D125944: Template instantiation error recovery.

@Purva-Chaudhari can you rebase this patch?

Sep 28 2022, 9:51 PM · Restricted Project

Aug 2 2022

Purva-Chaudhari committed rG168d4e2945a9: Handles failing driver tests of clang (authored by Purva-Chaudhari).
Handles failing driver tests of clang
Aug 2 2022, 12:02 AM · Restricted Project, Restricted Project
Purva-Chaudhari closed D125946: Handles failing driver tests of clang.
Aug 2 2022, 12:01 AM · Restricted Project, Restricted Project

Aug 1 2022

Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

Rebase

Aug 1 2022, 9:55 AM · Restricted Project
Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

Rebase

Aug 1 2022, 2:55 AM · Restricted Project

Jul 31 2022

Purva-Chaudhari added a comment to D125944: Template instantiation error recovery.

@Purva-Chaudhari can you rebase this patch?

Jul 31 2022, 8:22 PM · Restricted Project

Jul 13 2022

Purva-Chaudhari updated the diff for D125946: Handles failing driver tests of clang.

modify tests

Jul 13 2022, 5:56 AM · Restricted Project, Restricted Project

Jun 29 2022

Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

add preamble to test file

Jun 29 2022, 11:05 AM · Restricted Project
Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

Updating

Jun 29 2022, 10:51 AM · Restricted Project
Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

File name

Jun 29 2022, 6:21 AM · Restricted Project
Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

Added new file for template test

Jun 29 2022, 5:52 AM · Restricted Project

Jun 17 2022

Purva-Chaudhari added a comment to D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..

Asan tests passing! Solves the memory leak issue for original as well as modified version of execute.cpp (Commit issue solved )

Jun 17 2022, 1:11 AM · Restricted Project, Restricted Project

Jun 16 2022

Purva-Chaudhari added a comment to D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine..

@Purva-Chaudhari Could you check this out? Basically, this should allow even long execute.cpp test case to be ran without asan failures.

Jun 16 2022, 8:50 PM · Restricted Project, Restricted Project
Purva-Chaudhari added a comment to D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..

Hi @Purva-Chaudhari I haven't set up asan build setting yet. It's sad to hear it's still mem leaking. We need to look into somewhere else then...

Jun 16 2022, 6:17 AM · Restricted Project
Purva-Chaudhari added a comment to D127945: [Interpreter][ClangRepl] Call LLJIT deinitailize on exit..

Hi @sunho Did you test the changes after stage 2 asan build? The execute.cpp fails in my asan build area after adding this patch

Jun 16 2022, 6:01 AM · Restricted Project

Jun 11 2022

Purva-Chaudhari updated the diff for D123674: Clang-Repl Error Recovery Bug Fix.

Fix asan test fail

Jun 11 2022, 5:08 AM · Restricted Project, Restricted Project

May 31 2022

Purva-Chaudhari added a comment to D123674: Clang-Repl Error Recovery Bug Fix.

Hi,

I noticed that the testcase Interpreter/execute.cpp starts failing with this patch when run/compiled with asan:

Failed Tests (1):
  Clang :: Interpreter/execute.cpp

Seen in the buildbot run
https://lab.llvm.org/buildbot/#/builders/5/builds/24221

The run on the commit before passed:
https://lab.llvm.org/buildbot/#/builders/5/builds/24220

Thanks a lot for the notice @uabelho! I have reverted the patch while we are investigating.

@Purva-Chaudhari, can you take look and reproduce the asan failure locally?

May 31 2022, 1:09 AM · Restricted Project, Restricted Project

May 18 2022

Purva-Chaudhari updated the diff for D125944: Template instantiation error recovery.

Shifted private member

May 18 2022, 11:17 PM · Restricted Project
Purva-Chaudhari requested review of D125946: Handles failing driver tests of clang.
May 18 2022, 11:10 PM · Restricted Project, Restricted Project
Purva-Chaudhari requested review of D125944: Template instantiation error recovery.
May 18 2022, 10:46 PM · Restricted Project

Apr 13 2022

Purva-Chaudhari requested review of D123674: Clang-Repl Error Recovery Bug Fix.
Apr 13 2022, 5:47 AM · Restricted Project, Restricted Project