This is an archive of the discontinued LLVM Phabricator instance.

[clang][AArch64] Split neon tests into 2 files
AbandonedPublic

Authored by DavidSpickett on Apr 12 2022, 6:11 AM.

Details

Reviewers
None
Summary

This should reduce the per test execution time and prevent
timeouts in pre-commit buildkite builds.

(for #54821)

Diff Detail

Event Timeline

DavidSpickett created this revision.Apr 12 2022, 6:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 6:11 AM
DavidSpickett requested review of this revision.Apr 12 2022, 6:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 6:11 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Can't we add a timeout exception for this test in buildkite? Splitting the file in two actually increases the runtime, due to the overhead of setting up each test.

fhahn added a subscriber: fhahn.Apr 13 2022, 7:44 AM

Can't we add a timeout exception for this test in buildkite? Splitting the file in two actually increases the runtime, due to the overhead of setting up each test.

I don't know, this is a recurring issue which impacts multiple tests and we've not really heard from people maintaining build kite integration AFAIK.

Given that the split up files still contain many functions, I'd expect the setup cost to have a relatively small effect.

fhahn added a comment.Apr 13 2022, 7:45 AM

(splitting up huge monolithic tests likely also speeds up overall testing time on multi-core systems)

Ok, so maybe my concerns about testing overhead are not that legitimate. That's just something I've heard mentioned in the past. However, I still think this should be fixed in buildkite. It's seems much more sustainable to just bump the timeout in buildkite rather than having to go through the code and split tests every time they get too long. It sounds like the maintainers have been contacted about this, but haven't responded?

DavidSpickett abandoned this revision.Apr 22 2022, 1:36 AM

People are leaning toward fixes on the buildkite side.