This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add a definition of pthread_attr_t and its getters and setters.
ClosedPublic

Authored by sivachandra on Apr 8 2022, 2:30 PM.

Details

Summary

Not all attributes have been added to phtread_attr_t in this patch. They
will be added gradually in future patches.

Diff Detail

Event Timeline

sivachandra created this revision.Apr 8 2022, 2:30 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 8 2022, 2:30 PM
sivachandra requested review of this revision.Apr 8 2022, 2:30 PM
michaelrj added inline comments.Apr 8 2022, 2:37 PM
libc/src/pthread/pthread_attr_destroy.cpp
18

since this function doesn't appear to have an implementation yet, does it need to be in this patch?

Add a comment in the destroy function clarifying that there is nothing to cleanup.

sivachandra added inline comments.Apr 8 2022, 2:45 PM
libc/src/pthread/pthread_attr_destroy.cpp
18

That is the implementation. I have added a comment to make it clear.

lntue accepted this revision.Apr 9 2022, 12:36 PM
This revision is now accepted and ready to land.Apr 9 2022, 12:36 PM