This is an archive of the discontinued LLVM Phabricator instance.

Removed Expected Compilation Error
AbandonedPublic

Authored by ps-19 on Apr 8 2022, 5:33 AM.

Details

Summary

As given here , https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp#L114

abs() function is defined under cstdlib header file which is missing.

Name: Priyansh Singh
Email: priyansh.singh100@gmail.com

Diff Detail

Event Timeline

ps-19 created this revision.Apr 8 2022, 5:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 5:33 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
ps-19 requested review of this revision.Apr 8 2022, 5:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 5:33 AM
ps-19 edited the summary of this revision. (Show Details)Apr 8 2022, 10:16 AM
aaron.ballman requested changes to this revision.Apr 8 2022, 1:34 PM

I believe this header is already pulled in transitively; I'm not aware of any builds that are currently broken. Do you have more details on why this is needed?

This revision now requires changes to proceed.Apr 8 2022, 1:34 PM
ps-19 added a comment.Apr 9 2022, 12:53 AM

I too have a doubt that cstdlib may have been added through some another header file, but i was not sure about it.

I too have a doubt that cstdlib may have been added through some another header file, but i was not sure about it.

Then I would recommend abandoning this patch. This sort of change is great if it's solving an issue, but otherwise doesn't add much value because it's not really fixing anything.

ps-19 abandoned this revision.Apr 9 2022, 10:14 AM