This is an archive of the discontinued LLVM Phabricator instance.

Differential D123380

[flang] Handle dynamically optional argument in EXIT
ClosedPublic

Authored by jeanPerier on Apr 8 2022, 5:01 AM.

Details

Reviewers
clementval
schweitz
Commits
rG4535bb9b80ce: [flang] Handle dynamically optional argument in EXIT
Summary

The actual argument passed to STATUS may be a dummy OPTIONAL or a
disassociated POINTER/unallocated ALLOCATABLE.

Diff Detail

Event Timeline

jeanPerier created this revision.Apr 8 2022, 5:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 5:01 AM
Herald added subscribers: mehdi_amini, jdoerfert. · View Herald Transcript
jeanPerier requested review of this revision.Apr 8 2022, 5:01 AM
clementval accepted this revision.Apr 8 2022, 5:07 AM

LGTM

This revision is now accepted and ready to land.Apr 8 2022, 5:07 AM
Harbormaster completed remote builds in B158670: Diff 421490.Apr 8 2022, 5:21 AM
Closed by commit rG4535bb9b80ce: [flang] Handle dynamically optional argument in EXIT (authored by jeanPerier). · Explain WhyApr 8 2022, 6:52 AM
This revision was automatically updated to reflect the committed changes.
jeanPerier added a commit: rG4535bb9b80ce: [flang] Handle dynamically optional argument in EXIT.

Revision Contents

PathSize
flang/
lib/
Lower/
2 lines
test/
Lower/
Intrinsics/
40 lines

Diff 421490

flang/lib/Lower/IntrinsicCall.cpp

Show First 20 Lines • Show All 713 Lines • ▼ Show 20 Linesstatic constexpr IntrinsicHandler handlers[]{
&I::genEoshift, &I::genEoshift,
{{{"array", asBox}, {{{"array", asBox},
{"shift", asAddr}, {"shift", asAddr},
{"boundary", asBox, handleDynamicOptional}, {"boundary", asBox, handleDynamicOptional},
{"dim", asValue}}}, {"dim", asValue}}},
/*isElemental=*/false}, /*isElemental=*/false},
{"exit", {"exit",
&I::genExit, &I::genExit,
{{{"status", asValue}}}, {{{"status", asValue, handleDynamicOptional}}},
/*isElemental=*/false}, /*isElemental=*/false},
{"exponent", &I::genExponent}, {"exponent", &I::genExponent},
{"floor", &I::genFloor}, {"floor", &I::genFloor},
{"fraction", &I::genFraction}, {"fraction", &I::genFraction},
{"get_command_argument", {"get_command_argument",
&I::genGetCommandArgument, &I::genGetCommandArgument,
{{{"number", asValue}, {{{"number", asValue},
{"value", asAddr}, {"value", asAddr},
▲ Show 20 Lines • Show All 3,136 Lines • Show Last 20 Lines

flang/test/Lower/Intrinsics/exit-2.f90

  • This file was added.
! Test EXIT with dynamically optional arguments.
! RUN: bbc -emit-fir %s -o - | FileCheck %s
! CHECK-LABEL: func @_QPexit_opt_dummy(
! CHECK-SAME: %[[VAL_0:.*]]: !fir.ref<i32> {fir.bindc_name = "status", fir.optional}) {
subroutine exit_opt_dummy(status)
integer, optional :: status
call exit(status)
! CHECK: %[[VAL_1:.*]] = fir.is_present %[[VAL_0]] : (!fir.ref<i32>) -> i1
! CHECK: %[[VAL_2:.*]] = fir.if %[[VAL_1]] -> (i32) {
! CHECK: %[[VAL_3:.*]] = fir.load %[[VAL_0]] : !fir.ref<i32>
! CHECK: fir.result %[[VAL_3]] : i32
! CHECK: } else {
! CHECK: %[[VAL_4:.*]] = arith.constant 0 : i32
! CHECK: fir.result %[[VAL_4]] : i32
! CHECK: }
! CHECK: %[[VAL_5:.*]] = fir.call @_FortranAExit(%[[VAL_6:.*]]) : (i32) -> none
end subroutine
! CHECK-LABEL: func @_QPexit_pointer(
! CHECK-SAME: %[[VAL_0:.*]]: !fir.ref<!fir.box<!fir.ptr<i32>>> {fir.bindc_name = "status"}) {
subroutine exit_pointer(status)
integer, pointer :: status
call exit(status)
! CHECK: %[[VAL_1:.*]] = fir.load %[[VAL_0]] : !fir.ref<!fir.box<!fir.ptr<i32>>>
! CHECK: %[[VAL_2:.*]] = fir.box_addr %[[VAL_1]] : (!fir.box<!fir.ptr<i32>>) -> !fir.ptr<i32>
! CHECK: %[[VAL_3:.*]] = fir.convert %[[VAL_2]] : (!fir.ptr<i32>) -> i64
! CHECK: %[[VAL_4:.*]] = arith.constant 0 : i64
! CHECK: %[[VAL_5:.*]] = arith.cmpi ne, %[[VAL_3]], %[[VAL_4]] : i64
! CHECK: %[[VAL_6:.*]] = fir.if %[[VAL_5]] -> (i32) {
! CHECK: %[[VAL_7:.*]] = fir.load %[[VAL_0]] : !fir.ref<!fir.box<!fir.ptr<i32>>>
! CHECK: %[[VAL_8:.*]] = fir.box_addr %[[VAL_7]] : (!fir.box<!fir.ptr<i32>>) -> !fir.ptr<i32>
! CHECK: %[[VAL_9:.*]] = fir.load %[[VAL_8]] : !fir.ptr<i32>
! CHECK: fir.result %[[VAL_9]] : i32
! CHECK: } else {
! CHECK: %[[VAL_10:.*]] = arith.constant 0 : i32
! CHECK: fir.result %[[VAL_10]] : i32
! CHECK: }
! CHECK: %[[VAL_11:.*]] = fir.call @_FortranAExit(%[[VAL_12:.*]]) : (i32) -> none
end subroutine