This is an archive of the discontinued LLVM Phabricator instance.

[coroutines] Get an IntegerType from the value instead of defaulting to 64 bit
ClosedPublic

Authored by lanza on Apr 6 2022, 6:28 PM.

Details

Summary

This AliasPtr is being created always from an Int64 even for targets
where 32 bit is the proper type. e.g. “thumbv7-none-linux-android16”.
This causes the assert in the get func to fail as we're getting a 32
bit from the APInt.

Fix this by simply always just getting the type from the value instead.

Diff Detail

Event Timeline

lanza created this revision.Apr 6 2022, 6:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 6:28 PM
lanza requested review of this revision.Apr 6 2022, 6:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 6:28 PM
ChuanqiXu added a reviewer: ChuanqiXu.EditedApr 6 2022, 7:17 PM

When post a revision, it would be better to contain more context of the diff page. Generally, this could be done by adding the argument -U9999 when you generates the diff.

lanza updated this revision to Diff 421278.Apr 7 2022, 10:35 AM

update from repo

lanza added a comment.Apr 7 2022, 10:36 AM

When post a revision, it would be better to contain more context of the diff page. Generally, this could be done by adding the argument -U9999 when you generates the diff.

Sorry, don't typically use the raw diff submission, was just too lazy to fix my arcanist :P But good point!

ChuanqiXu accepted this revision.Apr 7 2022, 8:23 PM

LGTM.

This revision is now accepted and ready to land.Apr 7 2022, 8:23 PM
This revision was landed with ongoing or failed builds.Apr 25 2022, 11:11 AM
This revision was automatically updated to reflect the committed changes.