Page MenuHomePhabricator
Differential D123259

[clang][ExtractAPI] Fix appendSpace in DeclarationFragments
ClosedPublic
Actions

Authored by zixuw on Apr 6 2022, 2:46 PM.

Details

Reviewers
dang
ributzka
QuietMisdreavus
Commits
rGfe2c77a0065c: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments
Summary

There is a bug in DeclarationFragments::appendSpace where the space
character is added to a local copy of the last fragment.

Diff Detail

Event Timeline

zixuw created this revision.Apr 6 2022, 2:46 PM
Herald added a reviewer: dang. · View Herald TranscriptApr 6 2022, 2:46 PM
Herald added a project: Restricted Project. · View Herald Transcript
zixuw requested review of this revision.Apr 6 2022, 2:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 2:46 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
zixuw added reviewers: ributzka, QuietMisdreavus.Apr 6 2022, 2:47 PM
zixuw added a child revision: D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods.Apr 6 2022, 2:58 PM
QuietMisdreavus accepted this revision.Apr 6 2022, 3:33 PM

LGTM

This revision is now accepted and ready to land.Apr 6 2022, 3:33 PM
Harbormaster completed remote builds in B158345: Diff 421018.Apr 6 2022, 4:30 PM
dang accepted this revision.Apr 7 2022, 2:08 AM

LGTM thanks for spotting this!

This revision was landed with ongoing or failed builds.Apr 7 2022, 9:17 AM
Closed by commit rGfe2c77a0065c: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments (authored by zixuw). · Explain Why
This revision was automatically updated to reflect the committed changes.
zixuw added a commit: rGfe2c77a0065c: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments.

Revision Contents
Changeset List

PathSize
clang/
lib/
ExtractAPI/
4 lines
test/
ExtractAPI/
4 lines
4 lines
4 lines
6 lines
8 lines

Diff 421240

View Options

clang/lib/ExtractAPI/DeclarationFragments.cpp

Loading...
View Options

clang/test/ExtractAPI/global_record.c

Loading...
View Options

clang/test/ExtractAPI/global_record_multifile.c

Loading...
View Options

clang/test/ExtractAPI/macro_undefined.c

Loading...
View Options

clang/test/ExtractAPI/objc_category.m

Loading...
View Options

clang/test/ExtractAPI/objc_interface.m

Loading...