[test] Build test-suite::omptargetvv-test_parallel_for_allocate-50_parallel_for-c.test with -fno-pic

[MaskRay]

Summary

To work around an unknown failure when compiling with default -fPIE:
https://github.com/llvm/llvm-project/issues/54082

-fno-pic makes the current default explicit.

[Meinersbur]

Could you please add a comment in the CMakeLists.txt for why -fno-pic is need, possible with a link to the bug?

TEST_SUITE_SOLLVEVV_OFFLOADING_CFLAGS is a user-controlled parameter. Defining it using -DTEST_SUITE_SOLLVEVV_OFFLOADING_CFLAGS=... (like the buildbot configuration does) will overwrite -fno-pic. Hence, the buildbot would continue to fail.

[Meinersbur]

External/sollve_vv/CMakeLists.txt

117

If this is indeed an OpenMP bug and it should work with -fpic), the alternative is to remove it from the list of tests that are known to work.

However, my assumption is that D120305 applied the changed default to device-code as well, when it should only do so for host code.

[MaskRay]

External/sollve_vv/CMakeLists.txt

117

Removing it from the list sounds good as well. Perhaps you can be so kind to fix it ? :)

As-is, if it fails with CLANG_DEFAULT_PIE_ON_LINUX on Linux glibc systems, then likely it already fails on Linux musl.

[Meinersbur]

I disabled the test in rT1b938dc299ebd75f8c552ef3be727c67a22f89cd

[MaskRay]

Thanks!

External/sollve_vv/CMakeLists.txt

 # SOLLVE OpenMP Offloading Validation & Verification Suite
 # https://crpl.cis.udel.edu/ompvvsollve/
 
 include(External)
 
 option(TEST_SUITE_SOLLVEVV_FORCE_ALL "Execute all SOLLVE V&V tests, even those known to be unsupported by Clang" OFF)
 
-set(TEST_SUITE_SOLLVEVV_OFFLOADING_CFLAGS "-fopenmp-targets=nvptx64-nvidia-cuda;-Xopenmp-target;-march=sm_70" CACHE STRING "Compiler arguments for OpenMP offloading")
+set(TEST_SUITE_SOLLVEVV_OFFLOADING_CFLAGS "-fno-pic;-fopenmp-targets=nvptx64-nvidia-cuda;-Xopenmp-target;-march=sm_70" CACHE STRING "Compiler arguments for OpenMP offloading")
 set(TEST_SUITE_SOLLVEVV_OFFLOADING_LDFLAGS "-fopenmp-targets=nvptx64-nvidia-cuda;-Xopenmp-target;-march=sm_70;-lomptarget" CACHE STRING "Linker arguments for OpenMP offloading")
 
 set(TEST_SUITE_SOLLVEVV_EXPECT_PASS
     4.5/offloading_success.cpp
     4.5/offloading_success.c
     4.5/application_kernels/alpaka_complex_template.cpp
     4.5/application_kernels/linked_list.c
     4.5/application_kernels/mmm_target.c
set(TEST_SUITE_SOLLVEVV_EXPECT_PASS
     5.0/declare_mapper/test_declare_mapper_target_struct.c
     5.0/declare_target/test_declare_target_device_type_host.c
     5.0/declare_target/test_declare_target_nested.c
     5.0/declare_target/test_declare_target_parallel_for.c
     5.0/declare_variant/test_declare_variant.c
     5.0/flush/test_flush_no_memory_order_clause.c
     5.0/master_taskloop/test_master_taskloop.c
     5.0/master_taskloop_simd/test_master_taskloop_simd.c
     5.0/parallel_for/test_parallel_for_allocate.c
     5.0/parallel_for/test_parallel_for_notequals.c
     5.0/parallel_for/test_parallel_for_order_concurrent.c
     5.0/parallel_for_simd/test_parallel_for_simd_atomic.c
     5.0/parallel_master/test_parallel_master.c
     5.0/parallel_master_taskloop/test_parallel_master_taskloop.c
     5.0/parallel_master_taskloop_simd/test_parallel_master_taskloop_simd.c
     5.0/program_control/test_capture_omp_affinity.c
     5.0/program_control/test_omp_get_supported_active_levels.c