[clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[AaronSiddharthaMondal]

Summary

The new -config-file option introduced by 9e1f4f1 was accidentally referenced
as args.config_path on the python side. This patch renames args.config_path
to args.config_file.

To avoid confusion with python file objects, the input argument for
get_tidy_invocation has been renamed from config_path to config_file_path.

See GitHub issue #54728 for a discussion.

[aaron.ballman]

LGTM, thank you for the fix!

[aaron.ballman]

In D123074#3430351, @aaron.ballman wrote:

LGTM, thank you for the fix!

If you need me to commit on your behalf, what name and email address would you like me to use for patch attribution?

[AaronSiddharthaMondal]

In D123074#3430355, @aaron.ballman wrote:

In D123074#3430351, @aaron.ballman wrote:

LGTM, thank you for the fix!

If you need me to commit on your behalf, what name and email address would you like me to use for patch attribution?

Thanks, yes that would be nice :)

Name is Aaron Siddhartha Mondal. Email <[e-mail]>.
On GitHub its aaronmondal. I created the issue with another account.

[aaron.ballman]

In D123074#3430623, @AaronSiddharthaMondal wrote:

In D123074#3430355, @aaron.ballman wrote:

In D123074#3430351, @aaron.ballman wrote:

LGTM, thank you for the fix!

If you need me to commit on your behalf, what name and email address would you like me to use for patch attribution?

Thanks, yes that would be nice :)

Name is Aaron Siddhartha Mondal. Email <[e-mail]>.
On GitHub its aaronmondal. I created the issue with another account.

Thank you for the fix! I've commit on your behalf in 04b42c99f62216263662d1033fa9b3e12c65563e.

[AaronSiddharthaMondal]

@aaron.ballman There may have been something wrong with the commit. On GitHub it does not link to my user account. Would it be possible to change that?
The github name is aaronmondal.

[aaron.ballman]

In D123074#3430705, @AaronSiddharthaMondal wrote:

@aaron.ballman There may have been something wrong with the commit. On GitHub it does not link to my user account. Would it be possible to change that?
The github name is aaronmondal.

Sorry for the trouble -- the option to land with attribution takes name <email@address> form, not a GitHub username.

I can reland with different attribution, but that churns the git history and makes git blame harder for code archeology, so it's nice to avoid if possible. I think adding your secondary email address to your GitHub account should also address the issue (https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-user-account/managing-email-preferences/adding-an-email-address-to-your-github-account). But if it doesn't and you'd still like the attribution changed, I can revert and recommit (probably tomorrow at this point, I'm just about done for the day today).

[AaronSiddharthaMondal]

Ahh I didn't know that. After fixing my settings it is now linked correctly. No need to revert.

Thanks a lot for the help!

[aaron.ballman]

In D123074#3430789, @AaronSiddharthaMondal wrote:

Ahh I didn't know that. After fixing my settings it is now linked correctly. No need to revert.

I'm glad that worked for you!

Thanks a lot for the help!

Any time, thank you so much for the fix!

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

 def make_absolute(f, directory):
   if os.path.isabs(f):
     return f
   return os.path.normpath(os.path.join(directory, f))
 
 
 def get_tidy_invocation(f, clang_tidy_binary, checks, tmpdir, build_path,
                         header_filter, allow_enabling_alpha_checkers,
-                        extra_arg, extra_arg_before, quiet, config_path,
+                        extra_arg, extra_arg_before, quiet, config_file_path,
                         config, line_filter, use_color):
   """Gets a command line for clang-tidy."""
   start = [clang_tidy_binary]
   if allow_enabling_alpha_checkers:
     start.append('-allow-enabling-analyzer-alpha-checkers')
   if header_filter is not None:
     start.append('-header-filter=' + header_filter)
   if line_filter is not None:
if tmpdir is not None:
     start.append(name)
   for arg in extra_arg:
       start.append('-extra-arg=%s' % arg)
   for arg in extra_arg_before:
       start.append('-extra-arg-before=%s' % arg)
   start.append('-p=' + build_path)
   if quiet:
       start.append('-quiet')
-  if config_path:
-      start.append('--config-file=' + config_path)
+  if config_file_path:
+      start.append('--config-file=' + config_file_path)
   elif config:
       start.append('-config=' + config)
   start.append(f)
   return start
 
 
 def merge_replacement_files(tmpdir, mergefile):
   """Merge all replacement files in a directory into a single file"""
def run_tidy(args, clang_tidy_binary, tmpdir, build_path, queue, lock,
              failed_files):
   """Takes filenames out of queue and runs clang-tidy on them."""
   while True:
     name = queue.get()
     invocation = get_tidy_invocation(name, clang_tidy_binary, args.checks,
                                      tmpdir, build_path, args.header_filter,
                                      args.allow_enabling_alpha_checkers,
                                      args.extra_arg, args.extra_arg_before,
-                                     args.quiet, args.config_path, args.config,
+                                     args.quiet, args.config_file, args.config,
                                      args.line_filter, args.use_color)
 
     proc = subprocess.Popen(invocation, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     output, err = proc.communicate()
     if proc.returncode != 0:
       if proc.returncode < 0:
         msg = "%s: terminated by signal %d\n" % (name, -proc.returncode)
         err += msg.encode('utf-8')
clang_apply_replacements_binary = find_binary(
       build_path)
     tmpdir = tempfile.mkdtemp()
 
   try:
     invocation = get_tidy_invocation("", clang_tidy_binary, args.checks,
                                      None, build_path, args.header_filter,
                                      args.allow_enabling_alpha_checkers,
                                      args.extra_arg, args.extra_arg_before,
-                                     args.quiet, args.config_path, args.config,
+                                     args.quiet, args.config_file, args.config,
                                      args.line_filter, args.use_color)
     invocation.append('-list-checks')
     invocation.append('-')
     if args.quiet:
       # Even with -quiet we still want to check if we can call clang-tidy.
       with open(os.devnull, 'w') as dev_null:
         subprocess.check_call(invocation, stdout=dev_null)
     else: