This is an archive of the discontinued LLVM Phabricator instance.

InstCombineCalls: infer return alignment from allocalign attributes
ClosedPublic

Authored by durin42 on Apr 4 2022, 10:45 AM.

Details

Summary

This exposes a couple of lingering bugs, which will be fixed in
the next two commits.

Diff Detail

Event Timeline

durin42 created this revision.Apr 4 2022, 10:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 10:45 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
durin42 requested review of this revision.Apr 4 2022, 10:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 10:45 AM
nikic accepted this revision.Apr 6 2022, 2:10 AM
nikic added inline comments.
llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
2848

We're missing change reporting here -- annotateAnyAllocSite should return a boolean and we should initialize Changed with it. But this is orthogonal to your change here.

This revision is now accepted and ready to land.Apr 6 2022, 2:10 AM
durin42 updated this revision to Diff 420846.Apr 6 2022, 7:41 AM
durin42 edited the summary of this revision. (Show Details)
durin42 marked an inline comment as done.Apr 6 2022, 9:12 AM
durin42 added inline comments.
llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
2848

Sent a follow-up as D123232 (it's at the end of the stack now, but I'm happy to submit it if it's LG and this one is also ready)

This revision was landed with ongoing or failed builds.Apr 7 2022, 9:38 AM
This revision was automatically updated to reflect the committed changes.
durin42 marked an inline comment as done.