This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libc++] Modularize chrono's calendar.
ClosedPublic

Authored by Mordante on Apr 3 2022, 7:01 AM.

Details

Reviewers
ldionne
philnik
Group Reviewers
Restricted Project
Commits
rGd78624975b43: [NFC][libc++] Modularize chrono's calendar.
Summary

The is a followup of D116965 to split the calendar header. This is a
preparation to add the formatters for the chrono header.

The code is only moved no other changes have been made.

Diff Detail

Event Timeline

Mordante created this revision.Apr 3 2022, 7:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2022, 7:01 AM
Herald added a subscriber: mgorny. · View Herald Transcript
Mordante requested review of this revision.Apr 3 2022, 7:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2022, 7:01 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision as: philnik.Apr 3 2022, 7:08 AM
philnik added a subscriber: philnik.

LGTM, assuming you didn't change any of the implementation.

Mordante updated this revision to Diff 420051.Apr 3 2022, 7:14 AM

Forgot to commit the new generated tests.

Mordante updated this revision to Diff 420053.Apr 3 2022, 7:56 AM

Sort headers.

Mordante updated this revision to Diff 420057.Apr 3 2022, 8:40 AM

More sorting.

ldionne accepted this revision.Apr 4 2022, 2:18 PM

LGTM assuming you did not drop any transitive includes in the process. If you did, please keep them in <chrono> with a TODO to remove them. We can do it in bulk with a release note when we're ready.

Also, please poke CI just to make sure :)

This revision is now accepted and ready to land.Apr 4 2022, 2:18 PM
Mordante updated this revision to Diff 420526.Apr 5 2022, 8:38 AM

Rebase to test CI and update generated files.

LGTM assuming you did not drop any transitive includes in the process. If you did, please keep them in <chrono> with a TODO to remove them. We can do it in bulk with a release note when we're ready.

No all includes where used, some have been removed from calendar.h, but the headers I moved them are included by <chrono>.

Also, please poke CI just to make sure :)

I did, also made sure I removed the obsolete .verify files.

Mordante updated this revision to Diff 420588.Apr 5 2022, 11:45 AM

Remove an unrelated file from the test script.

This revision was automatically updated to reflect the committed changes.