This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Modularize <chrono>
ClosedPublic

Authored by ldionne on Jan 10 2022, 12:08 PM.

Details

Reviewers
Quuxplusone
Mordante
Group Reviewers
Restricted Project
Restricted Project
Commits
rG5726e5598104: [libc++] Modularize <chrono>
Summary

I didn't split the calendar bits more than this because there was little
benefit to doing it, and I know our calendar support is incomplete.
Whoever picks up the missing calendar bits can organize these headers
at their leisure.

Diff Detail

Event Timeline

ldionne created this revision.Jan 10 2022, 12:08 PM
ldionne requested review of this revision.Jan 10 2022, 12:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2022, 12:08 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Quuxplusone added a subscriber: Quuxplusone.

Looks great to me!

Mordante accepted this revision.Jan 11 2022, 8:44 AM
Mordante added a subscriber: Mordante.

Nice improvement, LGTM!

This revision is now accepted and ready to land.Jan 11 2022, 8:44 AM
ldionne updated this revision to Diff 399339.Jan 12 2022, 8:23 AM

Fix modular build.

ldionne updated this revision to Diff 399653.Jan 13 2022, 6:13 AM

Almost fix CI. I don't understand the last failure in libc++abi, since I am including <stdint.h> in the appropriate header. Can someone spot the issue?

Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2022, 6:13 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
This revision now requires review to proceed.Jan 13 2022, 6:13 AM

Almost fix CI. I don't understand the last failure in libc++abi, since I am including <stdint.h> in the appropriate header. Can someone spot the issue?

INT_MAX is in <climits>, not <cstdint>.

Almost fix CI. I don't understand the last failure in libc++abi, since I am including <stdint.h> in the appropriate header. Can someone spot the issue?

INT_MAX is in <climits>, not <cstdint>.

Ahh geez, I think WINT_MAX is the one defined in <cstdint> (according to cppreference at least). Thanks for spotting.

ldionne accepted this revision as: Restricted Project.Jan 14 2022, 6:55 AM
This revision is now accepted and ready to land.Jan 14 2022, 6:55 AM
This revision was automatically updated to reflect the committed changes.