This is an archive of the discontinued LLVM Phabricator instance.

Differential D122962

[Scudo] enabling anonymous named pages on Linux 5.17 and onwards.
ClosedPublic

Authored by devnexen on Apr 1 2022, 9:08 PM.

Details

Reviewers
vitalybuka
Commits
rG619499252307: [Scudo] enabling anonymous named pages on Linux 5.17 and onwards.

Diff Detail

Unit TestsFailed

TimeTest
50 msx64 debian > ScudoStandalone-Unit-GwpAsanTorture._/ScudoCUnitTest-x86_64-Test::ScudoWrappersCTest.MallocInfo
10 msx64 debian > ScudoStandalone-Unit._/ScudoCUnitTest-x86_64-Test::ScudoWrappersCTest.MallocInfo

Event Timeline

devnexen created this revision.Apr 1 2022, 9:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 9:08 PM
Herald added a subscriber: cryptoad. · View Herald Transcript
devnexen requested review of this revision.Apr 1 2022, 9:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 9:09 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B157556: Diff 419929.Apr 1 2022, 9:26 PM
vitalybuka accepted this revision.Apr 4 2022, 12:23 PM
This revision is now accepted and ready to land.Apr 4 2022, 12:23 PM
This revision was landed with ongoing or failed builds.Apr 5 2022, 1:47 AM
Closed by commit rG619499252307: [Scudo] enabling anonymous named pages on Linux 5.17 and onwards. (authored by devnexen). · Explain Why
This revision was automatically updated to reflect the committed changes.
devnexen added a commit: rG619499252307: [Scudo] enabling anonymous named pages on Linux 5.17 and onwards..
RKSimon added a subscriber: RKSimon.Apr 5 2022, 4:01 AM

@devnexen This looks like its causing problems on the ppc buildbots:
https://lab.llvm.org/buildbot/#/builders/100/builds/14355
https://lab.llvm.org/buildbot/#/builders/121/builds/18122
https://lab.llvm.org/buildbot/#/builders/105/builds/23720

abrachet added a subscriber: abrachet.Apr 5 2022, 8:19 AM

Seeing the same issues on some downstream bots. See for example https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8817718220408284977/overview

abrachet added a reverting change: rG016e59bf2cbf: Revert "[Scudo] enabling anonymous named pages on Linux 5.17 and onwards.".Apr 5 2022, 9:39 AM

Revision Contents

PathSize
compiler-rt/
lib/
scudo/
standalone/
12 lines

Diff 419929

compiler-rt/lib/scudo/standalone/linux.cpp

Context not available.
#include <time.h> #include <time.h>
#include <unistd.h> #include <unistd.h>
#if SCUDO_ANDROID
#include <sys/prctl.h> #include <sys/prctl.h>
// Definitions of prctl arguments to set a vma name in Android kernels. // Definitions of prctl arguments to set a vma name in kernels (Linux from 5.17).
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-// Definitions of prctl arguments to set a vma name in kernels (Linux from 5.17).
+// Definitions of prctl arguments to set a vma name in kernels (Linux
+// from 5.17).
Lint: Pre-merge checks: clang-format: please reformat the code ``` -// Definitions of prctl arguments to set a vma name…
#define ANDROID_PR_SET_VMA 0x53564d41 #ifndef PR_SET_VMA
#define ANDROID_PR_SET_VMA_ANON_NAME 0 #define PR_SET_VMA 0x53564d41
#define PR_SET_VMA_ANON_NAME 0
#endif #endif
namespace scudo { namespace scudo {
Context not available.
dieOnMapUnmapError(errno == ENOMEM ? Size : 0); dieOnMapUnmapError(errno == ENOMEM ? Size : 0);
return nullptr; return nullptr;
} }
#if SCUDO_ANDROID
if (Name) if (Name)
prctl(ANDROID_PR_SET_VMA, ANDROID_PR_SET_VMA_ANON_NAME, P, Size, Name); prctl(PR_SET_VMA, PR_SET_VMA_ANON_NAME, P, Size, Name);
#endif
return P; return P;
} }
Context not available.