This is an archive of the discontinued LLVM Phabricator instance.

Differential D122613

[Driver] Make -moutline-atomics default for aarch64-fuchsia targets
ClosedPublic

Authored by mcgrathr on Mar 28 2022, 2:06 PM.

Details

Reviewers
phosek
abrachet
Commits
rG1a963d3278c2: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets
Summary

This makes Fuchsia consistent with Linux on AArch64.

Diff Detail

Event Timeline

mcgrathr created this revision.Mar 28 2022, 2:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 2:06 PM
Herald added a subscriber: kristof.beyls. · View Herald Transcript
mcgrathr requested review of this revision.Mar 28 2022, 2:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 2:06 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
abrachet accepted this revision.Mar 28 2022, 2:21 PM
abrachet added inline comments.
clang/lib/Driver/ToolChains/Fuchsia.h
81
This revision is now accepted and ready to land.Mar 28 2022, 2:21 PM
This revision was landed with ongoing or failed builds.Mar 28 2022, 4:52 PM
Closed by commit rG1a963d3278c2: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets (authored by mcgrathr). · Explain Why
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rG1a963d3278c2: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets.
Harbormaster completed remote builds in B156638: Diff 418699.Mar 29 2022, 5:50 PM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
25 lines
test/
Driver/
1 line

Diff 418734

clang/lib/Driver/ToolChains/Fuchsia.h

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Linespublic:
std::string ComputeEffectiveClangTriple(const llvm::opt::ArgList &Args, std::string ComputeEffectiveClangTriple(const llvm::opt::ArgList &Args,
types::ID InputType) const override; types::ID InputType) const override;
SanitizerMask getSupportedSanitizers() const override; SanitizerMask getSupportedSanitizers() const override;
SanitizerMask getDefaultSanitizers() const override; SanitizerMask getDefaultSanitizers() const override;
RuntimeLibType RuntimeLibType
GetRuntimeLibType(const llvm::opt::ArgList &Args) const override; GetRuntimeLibType(const llvm::opt::ArgList &Args) const override;
CXXStdlibType CXXStdlibType GetCXXStdlibType(const llvm::opt::ArgList &Args) const override;
GetCXXStdlibType(const llvm::opt::ArgList &Args) const override;
void addClangTargetOptions(const llvm::opt::ArgList &DriverArgs, bool IsAArch64OutlineAtomicsDefault(
const llvm::opt::ArgList &Args) const override {
abrachetUnsubmitted
Not Done
ReplyInline Actions
bool IsAArch64OutlineAtomicsDefault(
- const llvm::opt::ArgList &Args) const override {
+ const llvm::opt::ArgList &) const override {
return true;
abrachet:
return true;
}
void
addClangTargetOptions(const llvm::opt::ArgList &DriverArgs,
llvm::opt::ArgStringList &CC1Args, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const override; Action::OffloadKind DeviceOffloadKind) const override;
void void
AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs, AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs,
llvm::opt::ArgStringList &CC1Args) const override; llvm::opt::ArgStringList &CC1Args) const override;
void void AddClangCXXStdlibIncludeArgs(
AddClangCXXStdlibIncludeArgs(const llvm::opt::ArgList &DriverArgs, const llvm::opt::ArgList &DriverArgs,
llvm::opt::ArgStringList &CC1Args) const override; llvm::opt::ArgStringList &CC1Args) const override;
void AddCXXStdlibLibArgs(const llvm::opt::ArgList &Args, void AddCXXStdlibLibArgs(const llvm::opt::ArgList &Args,
llvm::opt::ArgStringList &CmdArgs) const override; llvm::opt::ArgStringList &CmdArgs) const override;
const char *getDefaultLinker() const override { const char *getDefaultLinker() const override { return "ld.lld"; }
return "ld.lld";
}
protected: protected:
Tool *buildLinker() const override; Tool *buildLinker() const override;
}; };
} // end namespace toolchains } // end namespace toolchains
} // end namespace driver } // end namespace driver
} // end namespace clang } // end namespace clang
#endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_FUCHSIA_H #endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_FUCHSIA_H

clang/test/Driver/fuchsia.c

Show All 28 Lines
// CHECK: "--mrelax-relocations" // CHECK: "--mrelax-relocations"
// CHECK: "-funwind-tables=2" // CHECK: "-funwind-tables=2"
// CHECK: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
// CHECK: "-isysroot" "[[SYSROOT:[^"]+]]" // CHECK: "-isysroot" "[[SYSROOT:[^"]+]]"
// CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include" // CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include"
// CHECK-AARCH64: "-fsanitize=shadow-call-stack" // CHECK-AARCH64: "-fsanitize=shadow-call-stack"
// CHECK-X86_64: "-fsanitize=safe-stack" // CHECK-X86_64: "-fsanitize=safe-stack"
// CHECK: "-stack-protector" "2" // CHECK: "-stack-protector" "2"
// CHECK-AARCH64: "-target-feature" "+outline-atomics"
// CHECK-NOT: "-fcommon" // CHECK-NOT: "-fcommon"
// CHECK: {{.*}}ld.lld{{.*}}" "-z" "max-page-size=4096" "-z" "now" "-z" "rodynamic" "-z" "separate-loadable-segments" "-z" "rel" "--pack-dyn-relocs=relr" // CHECK: {{.*}}ld.lld{{.*}}" "-z" "max-page-size=4096" "-z" "now" "-z" "rodynamic" "-z" "separate-loadable-segments" "-z" "rel" "--pack-dyn-relocs=relr"
// CHECK: "--sysroot=[[SYSROOT]]" // CHECK: "--sysroot=[[SYSROOT]]"
// CHECK: "-pie" // CHECK: "-pie"
// CHECK: "--build-id" // CHECK: "--build-id"
// CHECK: "--hash-style=gnu" // CHECK: "--hash-style=gnu"
// CHECK: "-dynamic-linker" "ld.so.1" // CHECK: "-dynamic-linker" "ld.so.1"
// CHECK: Scrt1.o // CHECK: Scrt1.o
▲ Show 20 Lines • Show All 230 Lines • Show Last 20 Lines