This is an archive of the discontinued LLVM Phabricator instance.

[clang][extract-api] Add Objective-C protocol support
ClosedPublic

Authored by zixuw on Mar 25 2022, 3:18 PM.

Details

Summary

Add support for Objective-C protocol declarations in ExtractAPI.

Depends on D122446

Diff Detail

Event Timeline

zixuw created this revision.Mar 25 2022, 3:18 PM
Herald added a project: Restricted Project. · View Herald Transcript
zixuw requested review of this revision.Mar 25 2022, 3:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 3:18 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
dang added inline comments.Mar 28 2022, 1:49 PM
clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
269

I think we should be recording this in StringAllocator

clang/test/ExtractAPI/objc_interface.m
17 ↗(On Diff #418343)

Should this be done in the interfaces patch?

zixuw updated this revision to Diff 418744.Mar 28 2022, 5:22 PM
zixuw marked 2 inline comments as done.

Rebase upstream changes in D122446:

  • Move the change of the objc_interface.m test to D122446.
clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
269

Same reply and concern in D122446

dang accepted this revision.Mar 29 2022, 3:52 AM
This revision is now accepted and ready to land.Mar 29 2022, 3:52 AM
This revision was landed with ongoing or failed builds.Mar 29 2022, 2:45 PM
This revision was automatically updated to reflect the committed changes.