This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Make testcase warning pattern match more specific
ClosedPublic

Authored by rs on Mar 25 2022, 8:58 AM.

Download Raw Diff

Details

Reviewers

tstellar
lenary

Commits

rG4df69c1ff19f: [ARM] Make testcase warning pattern match more specific

Summary

Make the warning more specific as downstream compilers could produce other warnings.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rs created this revision.Mar 25 2022, 8:58 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 8:58 AM

Herald added a subscriber: kristof.beyls. · View Herald Transcript

rs requested review of this revision.Mar 25 2022, 8:58 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 8:58 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

rs edited the summary of this revision. (Show Details)Mar 25 2022, 9:00 AM

The reason I used a minimal check string is because if the warning text changes at all, then the test becomes useless (this is the downside of using -NOT). I wonder if there is another way to test this that might be robust? If not, then I think this change is fine.

Harbormaster completed remote builds in B156303: Diff 418243.Mar 25 2022, 9:25 AM

@tstellar thanks for the review. I can't really think of any other way to test this. I'll wait till Monday if no one else has suggested anything else then I'll commit it. Thanks again.

In D122487#3408425, @rs wrote:

@tstellar thanks for the review. I can't really think of any other way to test this. I'll wait till Monday if no one else has suggested anything else then I'll commit it. Thanks again.

OK, sounds good.

This revision is now accepted and ready to land.Mar 25 2022, 11:02 AM

Closed by commit rG4df69c1ff19f: [ARM] Make testcase warning pattern match more specific (authored by rs). · Explain WhyMar 28 2022, 6:44 AM

This revision was automatically updated to reflect the committed changes.

rs added a commit: rG4df69c1ff19f: [ARM] Make testcase warning pattern match more specific.

Revision Contents

Path

Size

clang/

test/

Driver/

aarch64-security-options.c

2 lines

Diff 418243

clang/test/Driver/aarch64-security-options.c

	Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
	// BAD-RA-PROTECTION: invalid branch protection option 'foo' in '-msign-return-address={{.*}}'			// BAD-RA-PROTECTION: invalid branch protection option 'foo' in '-msign-return-address={{.*}}'
	// BAD-BP-PROTECTION: invalid branch protection option 'bar' in '-mbranch-protection={{.*}}'			// BAD-BP-PROTECTION: invalid branch protection option 'bar' in '-mbranch-protection={{.*}}'

	// BAD-B-KEY-COMBINATION: invalid branch protection option 'b-key' in '-mbranch-protection={{.*}}'			// BAD-B-KEY-COMBINATION: invalid branch protection option 'b-key' in '-mbranch-protection={{.*}}'
	// BAD-LEAF-COMBINATION: invalid branch protection option 'leaf' in '-mbranch-protection={{.*}}'			// BAD-LEAF-COMBINATION: invalid branch protection option 'leaf' in '-mbranch-protection={{.*}}'

	// Check that the linker driver doesn't warn about -mbranch-protection=standard			// Check that the linker driver doesn't warn about -mbranch-protection=standard
	// as an unused option.			// as an unused option.
	// LINKER-DRIVER-NOT: warning:			// LINKER-DRIVER-NOT: warning: argument unused during compilation: '-mbranch-protection=standard'