inside template args
ClosedPublic
Actions

Authored by urnathan on Mar 25 2022, 4:40 AM.

Details

Reviewers

rjmccall
bruno
dblaikie

Group Reviewers

Restricted Project

Commits

rGee6ec9e861e6: [demangler] Parenthesize >> inside template args

Summary

Both > and >> expressions need to be parenthesized inside template argument lists.

(as noted in D120905)

Any opinions about removing the insertion of ' ' between consecutive template arg closing '>' chars? tpl<tpl<x>> vs tpl<tpl<x> >

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

urnathan created this revision.Mar 25 2022, 4:40 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 4:40 AM

urnathan requested review of this revision.Mar 25 2022, 4:40 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 4:40 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

urnathan added a parent revision: D120905: [demangler] Add operator precedence.Mar 25 2022, 4:41 AM

urnathan edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B156256: Diff 418186.Mar 25 2022, 5:56 AM

I think C++11 is pervasive enough that removing the space is fine. Demangler output is not necessarily valid source anyway.

Patch LGTM.

rebase

Harbormaster completed remote builds in B156611: Diff 418656.Mar 29 2022, 3:40 PM

In D122474#3409394, @rjmccall wrote:

I think C++11 is pervasive enough that removing the space is fine. Demangler output is not necessarily valid source anyway.

Patch LGTM.

I'll take that as approval, unless someone chimes in in the next couple of days.

urnathan added a reviewer: Restricted Project.Mar 31 2022, 8:44 AM

In D122474#3419012, @urnathan wrote:

In D122474#3409394, @rjmccall wrote:

I think C++11 is pervasive enough that removing the space is fine. Demangler output is not necessarily valid source anyway.

Patch LGTM.

I'll take that as approval, unless someone chimes in in the next couple of days.