This is an archive of the discontinued LLVM Phabricator instance.

demangler] Parenthesize >> inside template args
ClosedPublic

Authored by urnathan on Mar 25 2022, 4:40 AM.

Details

Summary

Both > and >> expressions need to be parenthesized inside template argument lists.

(as noted in D120905)

Any opinions about removing the insertion of ' ' between consecutive template arg closing '>' chars? tpl<tpl<x>> vs tpl<tpl<x> >

Diff Detail

Event Timeline

urnathan created this revision.Mar 25 2022, 4:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 4:40 AM
urnathan requested review of this revision.Mar 25 2022, 4:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 4:40 AM
urnathan edited the summary of this revision. (Show Details)

I think C++11 is pervasive enough that removing the space is fine. Demangler output is not necessarily valid source anyway.

Patch LGTM.

I think C++11 is pervasive enough that removing the space is fine. Demangler output is not necessarily valid source anyway.

Patch LGTM.

I'll take that as approval, unless someone chimes in in the next couple of days.

urnathan added a reviewer: Restricted Project.Mar 31 2022, 8:44 AM
dblaikie accepted this revision.Mar 31 2022, 1:42 PM

I think C++11 is pervasive enough that removing the space is fine. Demangler output is not necessarily valid source anyway.

Patch LGTM.

I'll take that as approval, unless someone chimes in in the next couple of days.

Yep, sounds good!

This revision is now accepted and ready to land.Mar 31 2022, 1:42 PM
This revision was landed with ongoing or failed builds.Apr 4 2022, 6:36 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 6:36 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript