Both > and >> expressions need to be parenthesized inside template argument lists.
(as noted in D120905)
Any opinions about removing the insertion of ' ' between consecutive template arg closing '>' chars? tpl<tpl<x>> vs tpl<tpl<x> >
Paths
| Differential D122474
demangler] Parenthesize >> inside template args ClosedPublic Authored by urnathan on Mar 25 2022, 4:40 AM.
Details
Summary Both > and >> expressions need to be parenthesized inside template argument lists. (as noted in D120905) Any opinions about removing the insertion of ' ' between consecutive template arg closing '>' chars? tpl<tpl<x>> vs tpl<tpl<x> >
Diff Detail
Unit TestsFailed Event TimelineComment Actions I think C++11 is pervasive enough that removing the space is fine. Demangler output is not necessarily valid source anyway. Patch LGTM. Comment Actions
I'll take that as approval, unless someone chimes in in the next couple of days. Comment Actions
Yep, sounds good! This revision is now accepted and ready to land.Mar 31 2022, 1:42 PM This revision was landed with ongoing or failed builds.Apr 4 2022, 6:36 AM Closed by commit rGee6ec9e861e6: [demangler] Parenthesize >> inside template args (authored by urnathan). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 418656 libcxxabi/src/demangle/ItaniumDemangle.h
libcxxabi/test/test_demangle.pass.cpp
llvm/include/llvm/Demangle/ItaniumDemangle.h
|