This is an archive of the discontinued LLVM Phabricator instance.

Differential D122298

[clang-cl] Ignore /Wv and /Wv:17 flags
ClosedPublic

Authored by thieta on Mar 23 2022, 1:55 AM.

Details

Reviewers
hans
mstorsjo
rnk
jdoerfert
Commits
rG67d9276b1602: [clang-cl] Ignore /Wv and /Wv:17 flags
Summary

MSVC supports passing /Wv and /Wv:17 to ignore warnings added
since that version. Clang doesn't have a option like this - but
we can ignore this flag instead of error.

MSVC documentation: https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level

Diff Detail

Event Timeline

thieta created this revision.Mar 23 2022, 1:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2022, 1:55 AM
thieta requested review of this revision.Mar 23 2022, 1:55 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMar 23 2022, 1:55 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: sstefan1. · View Herald Transcript
thieta updated this revision to Diff 417533.Mar 23 2022, 1:59 AM

Added back removed blank line

clang/include/clang/Driver/Options.td
2498–2499

Do we mind removing these trailing whitespaces in the same commit? I can fix that - but they shouldn't be there anyway.

mstorsjo accepted this revision.Mar 23 2022, 2:11 AM

The patch itself seems sensible to me.

clang/include/clang/Driver/Options.td
2498–2499

I think it'd be fine to just push such a commit without taking it through review, marked as NFC (no functional changes). Or keep it here but split it out into a separate commit before pushing.

This revision is now accepted and ready to land.Mar 23 2022, 2:11 AM
thieta updated this revision to Diff 417537.Mar 23 2022, 2:22 AM

Split whitespace to it's own commit

thieta added a comment.Mar 23 2022, 2:24 AM

Pushed the whitespace fix as a NFC here: https://github.com/llvm/llvm-project/commit/09c0685a043dd4028545c134b562c2605e294855

thieta marked an inline comment as done.Mar 23 2022, 2:24 AM
Harbormaster completed remote builds in B155809: Diff 417537.Mar 23 2022, 2:57 AM
hans accepted this revision.Mar 23 2022, 2:58 AM

Looks great, thanks!

Closed by commit rG67d9276b1602: [clang-cl] Ignore /Wv and /Wv:17 flags (authored by thieta). · Explain WhyMar 24 2022, 1:42 AM
This revision was automatically updated to reflect the committed changes.
thieta added a commit: rG67d9276b1602: [clang-cl] Ignore /Wv and /Wv:17 flags.

Revision Contents

PathSize
clang/
include/
clang/
Driver/
1 line
test/
Driver/
2 lines

Diff 417849

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,489 Lines • ▼ Show 20 Lines
def fopenmp_assume_teams_oversubscription : Flag<["-"], "fopenmp-assume-teams-oversubscription">, def fopenmp_assume_teams_oversubscription : Flag<["-"], "fopenmp-assume-teams-oversubscription">,
Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
def fopenmp_assume_threads_oversubscription : Flag<["-"], "fopenmp-assume-threads-oversubscription">, def fopenmp_assume_threads_oversubscription : Flag<["-"], "fopenmp-assume-threads-oversubscription">,
Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
def fno_openmp_assume_teams_oversubscription : Flag<["-"], "fno-openmp-assume-teams-oversubscription">, def fno_openmp_assume_teams_oversubscription : Flag<["-"], "fno-openmp-assume-teams-oversubscription">,
Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
def fno_openmp_assume_threads_oversubscription : Flag<["-"], "fno-openmp-assume-threads-oversubscription">, def fno_openmp_assume_threads_oversubscription : Flag<["-"], "fno-openmp-assume-threads-oversubscription">,
Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
def fopenmp_assume_no_thread_state : Flag<["-"], "fopenmp-assume-no-thread-state">, Group<f_Group>, def fopenmp_assume_no_thread_state : Flag<["-"], "fopenmp-assume-no-thread-state">, Group<f_Group>,
Flags<[CC1Option, NoArgumentUnused, HelpHidden]>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>,
thietaAuthorUnsubmitted
Done
ReplyInline Actions

Do we mind removing these trailing whitespaces in the same commit? I can fix that - but they shouldn't be there anyway.

thieta: Do we mind removing these trailing whitespaces in the same commit? I can fix that - but they…
mstorsjoUnsubmitted
Done
ReplyInline Actions

I think it'd be fine to just push such a commit without taking it through review, marked as NFC (no functional changes). Or keep it here but split it out into a separate commit before pushing.

mstorsjo: I think it'd be fine to just push such a commit without taking it through review, marked as NFC…
HelpText<"Assert no thread in a parallel region modifies an ICV">, HelpText<"Assert no thread in a parallel region modifies an ICV">,
MarshallingInfoFlag<LangOpts<"OpenMPNoThreadState">>; MarshallingInfoFlag<LangOpts<"OpenMPNoThreadState">>;
def fopenmp_offload_mandatory : Flag<["-"], "fopenmp-offload-mandatory">, Group<f_Group>, def fopenmp_offload_mandatory : Flag<["-"], "fopenmp-offload-mandatory">, Group<f_Group>,
Flags<[CC1Option, NoArgumentUnused]>, Flags<[CC1Option, NoArgumentUnused]>,
HelpText<"Do not create a host fallback if offloading to the device fails.">, HelpText<"Do not create a host fallback if offloading to the device fails.">,
MarshallingInfoFlag<LangOpts<"OpenMPOffloadMandatory">>; MarshallingInfoFlag<LangOpts<"OpenMPOffloadMandatory">>;
defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime",
LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue, LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,
▲ Show 20 Lines • Show All 4,017 Lines • ▼ Show 20 Lines
def _SLASH_kernel_ : CLIgnoredFlag<"kernel-">; def _SLASH_kernel_ : CLIgnoredFlag<"kernel-">;
def _SLASH_nologo : CLIgnoredFlag<"nologo">; def _SLASH_nologo : CLIgnoredFlag<"nologo">;
def _SLASH_RTC : CLIgnoredJoined<"RTC">; def _SLASH_RTC : CLIgnoredJoined<"RTC">;
def _SLASH_sdl : CLIgnoredFlag<"sdl">; def _SLASH_sdl : CLIgnoredFlag<"sdl">;
def _SLASH_sdl_ : CLIgnoredFlag<"sdl-">; def _SLASH_sdl_ : CLIgnoredFlag<"sdl-">;
def _SLASH_utf8 : CLIgnoredFlag<"utf-8">, def _SLASH_utf8 : CLIgnoredFlag<"utf-8">,
HelpText<"Set source and runtime encoding to UTF-8 (default)">; HelpText<"Set source and runtime encoding to UTF-8 (default)">;
def _SLASH_w : CLIgnoredJoined<"w">; def _SLASH_w : CLIgnoredJoined<"w">;
def _SLASH_Wv_ : CLIgnoredJoined<"Wv">;
def _SLASH_Zc___cplusplus : CLIgnoredFlag<"Zc:__cplusplus">; def _SLASH_Zc___cplusplus : CLIgnoredFlag<"Zc:__cplusplus">;
def _SLASH_Zc_auto : CLIgnoredFlag<"Zc:auto">; def _SLASH_Zc_auto : CLIgnoredFlag<"Zc:auto">;
def _SLASH_Zc_forScope : CLIgnoredFlag<"Zc:forScope">; def _SLASH_Zc_forScope : CLIgnoredFlag<"Zc:forScope">;
def _SLASH_Zc_inline : CLIgnoredFlag<"Zc:inline">; def _SLASH_Zc_inline : CLIgnoredFlag<"Zc:inline">;
def _SLASH_Zc_rvalueCast : CLIgnoredFlag<"Zc:rvalueCast">; def _SLASH_Zc_rvalueCast : CLIgnoredFlag<"Zc:rvalueCast">;
def _SLASH_Zc_ternary : CLIgnoredFlag<"Zc:ternary">; def _SLASH_Zc_ternary : CLIgnoredFlag<"Zc:ternary">;
def _SLASH_Zc_wchar_t : CLIgnoredFlag<"Zc:wchar_t">; def _SLASH_Zc_wchar_t : CLIgnoredFlag<"Zc:wchar_t">;
def _SLASH_ZH_MD5 : CLIgnoredFlag<"ZH:MD5">; def _SLASH_ZH_MD5 : CLIgnoredFlag<"ZH:MD5">;
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines

clang/test/Driver/cl-options.c

Show First 20 Lines • Show All 390 Lines • ▼ Show 20 Lines
// RUN: /sdl \ // RUN: /sdl \
// RUN: /sdl- \ // RUN: /sdl- \
// RUN: /source-charset:utf-8 \ // RUN: /source-charset:utf-8 \
// RUN: /utf-8 \ // RUN: /utf-8 \
// RUN: /vmg \ // RUN: /vmg \
// RUN: /volatile:iso \ // RUN: /volatile:iso \
// RUN: /w12345 \ // RUN: /w12345 \
// RUN: /wd1234 \ // RUN: /wd1234 \
// RUN: /Wv \
// RUN: /Wv:17 \
// RUN: /Zc:__cplusplus \ // RUN: /Zc:__cplusplus \
// RUN: /Zc:auto \ // RUN: /Zc:auto \
// RUN: /Zc:forScope \ // RUN: /Zc:forScope \
// RUN: /Zc:inline \ // RUN: /Zc:inline \
// RUN: /Zc:rvalueCast \ // RUN: /Zc:rvalueCast \
// RUN: /Zc:ternary \ // RUN: /Zc:ternary \
// RUN: /Zc:wchar_t \ // RUN: /Zc:wchar_t \
// RUN: /ZH:MD5 \ // RUN: /ZH:MD5 \
▲ Show 20 Lines • Show All 385 Lines • Show Last 20 Lines