Run check-mlir with ROCM flags to catch build breaks
Details
Diff Detail
Event Timeline
Thanks for the patch, Paul!
Could you remove the unrelated formatting changes, please? If you'd like, please feel free to propose a separate NFC patch with these changes.
Everything else looks good.
Did you do that the other way around? :)
I see only removed trailing white spaces in this patch now.
Directions said to make the commit and do "arc diff". "arc diff" said it no longer assumes HEAD^ so I did "arc diff HEAD^". That came up as a creation and not an update so I did "arc diff HEAD^ --update D122168" and here we are.
Diff 417339 shows the whitespace added. I can't figure out how to display the union of the two diffs.
I'd just make a new clean diff with only related changes and upload it through the Phabricator WebUI. This might be more controllable and straight forward.
I can commit on your behalf.
But before that, I'll need a password for the new worker. You can either send it to me directly, or I can assign a random one and send it to you.
Please let me know what you prefer.