ROCm test support for buildbot.

[pcf000]

Summary

Run check-mlir with ROCM flags to catch build breaks

[gkistanova]

Thanks for the patch, Paul!

Could you remove the unrelated formatting changes, please? If you'd like, please feel free to propose a separate NFC patch with these changes.
Everything else looks good.

[pcf000]

Restoring some trailing whitespace.

[gkistanova]

Did you do that the other way around? :)
I see only removed trailing white spaces in this patch now.

[pcf000]

Directions said to make the commit and do "arc diff". "arc diff" said it no longer assumes HEAD^ so I did "arc diff HEAD^". That came up as a creation and not an update so I did "arc diff HEAD^ --update D122168" and here we are.

[pcf000]

Diff 417339 shows the whitespace added. I can't figure out how to display the union of the two diffs.

[gkistanova]

I'd just make a new clean diff with only related changes and upload it through the Phabricator WebUI. This might be more controllable and straight forward.

[pcf000]

Removed some spurious whitespace changes (I hope).

[gkistanova]

LGTM

[pcf000]

Re-upload to pass pre-merge checks.

[pcf000]

It appears that I do not have landing permission.

[gkistanova]

I can commit on your behalf.
But before that, I'll need a password for the new worker. You can either send it to me directly, or I can assign a random one and send it to you.
Please let me know what you prefer.

[pcf000]

Password sent to [e-mail] from [e-mail]. Thanks.

buildbot/osuosl/master/config/builders.py

'factory' : BOLTBuilder.getBOLTCmakeBuildFactory(
                         "-DLLVM_TARGETS_TO_BUILD=X86;AArch64",
                         "-DBUILD_SHARED_LIBS=ON",
                         "-DLLVM_ENABLE_LLD=ON",
                         "-DBOLT_CLANG_EXE=/usr/bin/clang-12",
                         "-DBOLT_LLD_EXE=/usr/bin/ld.lld-12",
                         ],
                     )},
 
+    # AMD ROCm support.
+    {'name' : 'mlir-rocm-mi200',
+     'tags'  : ["mlir"],
+     'collapseRequests' : False,
+     'workernames' : ['mi200-buildbot'],
+     'builddir': 'mlir-rocm-mi200',
+     'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
+         clean=True,
+         depends_on_projects=['llvm', 'mlir'],
+         targets = ['check-mlir-build-only'],
+         checks = ['check-mlir'],
+         extra_configure_args= mlir_default_cmake_options + [
+             '-DLLVM_CCACHE_BUILD=ON',
+             '-DLLVM_ENABLE_ASSERTIONS=ON',
+             '-DLLVM_ENABLE_LLD=ON',
+             '-DMLIR_ENABLE_ROCM_RUNNER=ON',
+             '-DMLIR_ENABLE_ROCM_CONVERSIONS=ON',
+             '-DMLIR_INCLUDE_INTEGRATION_TESTS=ON',
+         ],
+         env={
+             'CC': 'clang',
+             'CXX': 'clang++',
+             'LD': 'lld',
+         })}
+
 ]

buildbot/osuosl/master/config/status.py

reporters.MailNotifier(
         sendToInterestedUsers = False,
         extraRecipients=["[e-mail]"],
         subject = "Build Failure: %(builder)s",
         mode = "failing",
         builders = ["openmp-offload-amdgpu-runtime"]),
     reporters.MailNotifier(
         fromaddr="[e-mail]",
         sendToInterestedUsers = False,
+        extraRecipients=["[e-mail]"],
+        subject = "Build Failure: %(builder)s",
+        mode = "failing",
+        builders = ["mlir-rocm-mi200"])
+    reporters.MailNotifier(
+        fromaddr="[e-mail]",
+        sendToInterestedUsers = False,
         extraRecipients=["[e-mail]"],
         subject = "Build Failure (flang): %(builder)s",
         mode = "failing",
         builders = ["flang-x86_64-windows"]),
     reporters.MailNotifier(
         fromaddr="[e-mail]",
         sendToInterestedUsers = False,
         extraRecipients=["[e-mail]"],

buildbot/osuosl/master/config/workers.py

return [
 
         # ARC Worker, CentOS 7.9 x86_64 Intel Xeon Platinum 8000 @ 3.6GHz, 32GB RAM
         create_worker("arc-worker", properties={'jobs': 16}, max_builds=1),
 
         # OpenMP on AMDGPU, Ubuntu 18.04.5, Intel(R) Xeon(R) Gold 5218 @ 2.30GHz with 64GB Memory, 1 Vega20 GPU with 16GB Memory
         create_worker("omp-vega20-0", properties={'jobs': 32}, max_builds=1),
         create_worker("omp-vega20-1", properties={'jobs': 32}, max_builds=1),
 
+        # AMD ROCm support, Ubuntu 18.04.6, AMD Ryzen @ 1.5 GHz, MI200 GPU
+        create_worker("mi200-buildbot", max_builds=1)
+
         # BOLT worker
         create_worker("bolt-worker", properties={'jobs' : 16}, max_builds=1),
         ]