This is an archive of the discontinued LLVM Phabricator instance.

Differential D121982

[Xcore] Set Int_MemBarrier as a meta-instruction
ClosedPublic

Authored by skan on Mar 18 2022, 12:45 AM.

Details

Reviewers
nigelp-xmos
robertlytton
Commits
rGea9139fe1666: [Xcore] Set Int_MemBarrier as a meta-instruction

Diff Detail

Unit TestsFailed

TimeTest
60,310 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg_mask.c
60,290 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg_mask_mf.c
60,250 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vlseg_mask.c
60,400 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vlsegff_mask.c
60,260 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg_mask.c
View Full Test Results (17 Failed)

Event Timeline

skan created this revision.Mar 18 2022, 12:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 12:45 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
skan requested review of this revision.Mar 18 2022, 12:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 12:45 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
skan added reviewers: nigelp-xmos, robertlytton.Mar 18 2022, 12:49 AM
Harbormaster completed remote builds in B154988: Diff 416411.Mar 18 2022, 2:00 AM
nigelp-xmos added a comment.Mar 18 2022, 6:09 AM

As the test is specifying targets, I think it needs to be in both X86 and XCore areas. Otherwise compilers not supporting those targets will attempt the test.

There is "REQUIRES: ...-registered-target" (for example in attr-btf_tag.ll) but I think "REQUIRES: x86-registered-target,xcore-registered-target" would only test compilers supporting both targets, which is not right.

I suppose an alternative to duplicating is a new REQUIRES name but perhaps that's excessive for one test, and duplicating is simplest?

skan added a comment.Mar 18 2022, 11:48 PM
In D121982#3392172, @nigelp-xmos wrote:

As the test is specifying targets, I think it needs to be in both X86 and XCore areas. Otherwise compilers not supporting those targets will attempt the test.

There is "REQUIRES: ...-registered-target" (for example in attr-btf_tag.ll) but I think "REQUIRES: x86-registered-target,xcore-registered-target" would only test compilers supporting both targets, which is not right.

I suppose an alternative to duplicating is a new REQUIRES name but perhaps that's excessive for one test, and duplicating is simplest?

Thanks! Good catch! I will do that.

skan updated this revision to Diff 416674.Mar 19 2022, 2:05 AM

Duplicate the test

Herald added a subscriber: ormris. · View Herald TranscriptMar 19 2022, 2:05 AM
nigelp-xmos accepted this revision.Mar 19 2022, 2:21 AM

LGTM thanks

This revision is now accepted and ready to land.Mar 19 2022, 2:21 AM
This revision was landed with ongoing or failed builds.Mar 19 2022, 2:52 AM
Closed by commit rGea9139fe1666: [Xcore] Set Int_MemBarrier as a meta-instruction (authored by skan). · Explain Why
This revision was automatically updated to reflect the committed changes.
skan added a commit: rGea9139fe1666: [Xcore] Set Int_MemBarrier as a meta-instruction.
Harbormaster completed remote builds in B155180: Diff 416674.Mar 19 2022, 2:56 AM

Revision Contents

PathSize
llvm/
lib/
Target/
XCore/
2 lines
test/
DebugInfo/
XCore/
32 lines
2 lines

Diff 416674

llvm/lib/Target/XCore/XCoreInstrInfo.td

Show First 20 Lines • Show All 357 Lines • ▼ Show 20 Lines
let usesCustomInserter = 1 in { let usesCustomInserter = 1 in {
def SELECT_CC : PseudoInstXCore<(outs GRRegs:$dst), def SELECT_CC : PseudoInstXCore<(outs GRRegs:$dst),
(ins GRRegs:$cond, GRRegs:$T, GRRegs:$F), (ins GRRegs:$cond, GRRegs:$T, GRRegs:$F),
"# SELECT_CC PSEUDO!", "# SELECT_CC PSEUDO!",
[(set GRRegs:$dst, [(set GRRegs:$dst,
(select GRRegs:$cond, GRRegs:$T, GRRegs:$F))]>; (select GRRegs:$cond, GRRegs:$T, GRRegs:$F))]>;
} }
let hasSideEffects = 1 in let hasSideEffects = 1, isMeta = 1 in
def Int_MemBarrier : PseudoInstXCore<(outs), (ins), "#MEMBARRIER", def Int_MemBarrier : PseudoInstXCore<(outs), (ins), "#MEMBARRIER",
[(XCoreMemBarrier)]>; [(XCoreMemBarrier)]>;
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Instructions // Instructions
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Three operand short // Three operand short
▲ Show 20 Lines • Show All 941 Lines • Show Last 20 Lines

llvm/test/DebugInfo/XCore/dwarf-mem-barrier.ll

  • This file was added.
; Check .loc directive is emitted at correct position
; RUN: llc -O0 -mtriple xcore-linux-gnu <%s | FileCheck %s
; CHECK: #MEMBARRIER
; CHECK: #MEMBARRIER
; CHECK: ldc r0, 0
; CHECK: stw r0, sp[0]
; CHECK: .loc 1 1 14 prologue_end # none.c:1:14
define dso_local i32 @main() !dbg !7 {
entry:
fence acquire, !dbg !9
fence release, !dbg !9
%retval = alloca i32, align 4
store i32 0, i32* %retval, align 4
ret i32 0, !dbg !9
}
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!3, !4, !5}
!llvm.ident = !{!6}
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang", isOptimized: false, runtimeVersion: 0, emissionKind: DebugDirectivesOnly, enums: !2, splitDebugInlining: false, nameTableKind: None)
!1 = !DIFile(filename: "none.c", directory: "/temp")
!2 = !{}
!3 = !{i32 2, !"Tracing", i32 1}
!4 = !{i32 2, !"Debug Info Version", i32 3}
!5 = !{i32 1, !"wchar_size", i32 4}
!6 = !{!"clang version 11.0.0"}
!7 = distinct !DISubprogram(name: "main", scope: !1, file: !1, line: 1, type: !8, scopeLine: 1, spFlags: DISPFlagDefinition, unit: !0, retainedNodes: !2)
!8 = !DISubroutineType(types: !2)
!9 = !DILocation(line: 1, column: 14, scope: !7)

llvm/test/DebugInfo/XCore/lit.local.cfg

  • This file was added.
if not 'XCore' in config.root.targets:
config.unsupported = True