This is an archive of the discontinued LLVM Phabricator instance.

Correct and complete dependency sets after 74b411d38c48513a125e67e049aca55452b9e855
ClosedPublic

Authored by saugustine on Mar 17 2022, 7:34 PM.

Details

Summary

Prior to this change the __support_cpp_array_ref target's only dependency was libc_root.
but it #includes "TypeTraits.h" and Array.h for that matter.

These dependencies matter when building in distributed build systems and the relevant
files must be know for the distributed build to ship them to the executor.

Diff Detail

Event Timeline

saugustine created this revision.Mar 17 2022, 7:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2022, 7:34 PM
saugustine requested review of this revision.Mar 17 2022, 7:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2022, 7:34 PM
abrachet accepted this revision.Mar 17 2022, 7:40 PM
This revision is now accepted and ready to land.Mar 17 2022, 7:40 PM
dblaikie accepted this revision.Mar 17 2022, 7:40 PM
dblaikie added a subscriber: dblaikie.

Sounds plausible to me - once the pre-merge checks come back green.

rtp accepted this revision.Mar 17 2022, 7:42 PM
This revision was automatically updated to reflect the committed changes.