This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Don't unmap other low memory pages if mapping doesn't exist
ClosedPublic

Authored by ddcc on Mar 16 2022, 2:15 PM.

Details

Summary

Tests can register multiple allocators, but only the first will initialize since it initializes the TSDRegistrySharedT. Then, destruction of subsequent allocator may end up unmapping a nullptr PrimaryBase with non-zero PrimarySize.

Diff Detail

Event Timeline

ddcc created this revision.Mar 16 2022, 2:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 2:15 PM
ddcc requested review of this revision.Mar 16 2022, 2:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 2:15 PM
vitalybuka accepted this revision.Mar 16 2022, 3:31 PM
vitalybuka added inline comments.
compiler-rt/lib/scudo/standalone/primary64.h
93

please clangformat

This revision is now accepted and ready to land.Mar 16 2022, 3:31 PM
This revision was landed with ongoing or failed builds.Mar 17 2022, 10:17 AM
This revision was automatically updated to reflect the committed changes.