[scudo] Use templated builtins to avoid assumptions on SCUDO_WORDSIZE

[ddcc]

Summary

Platforms may define uintptr_t differently, so just use template overrides to select the appropriate builtin

[ddcc]

@vitalybuka ping

[vitalybuka]

compiler-rt/lib/scudo/standalone/wrappers_c_checks.h

50

Looks like not it's going to accept even signed or float types, but will not optimize unsigned long long
maybe just cast in existing implementation?
_builtin_umull_overflow(Size, N, reinterpret_cast<unsigned long*>Product);

[ddcc]

Use cast instead of template

[vitalybuka]

compiler-rt/lib/scudo/standalone/wrappers_c_checks.h

50–51

same here?

compiler-rt/lib/scudo/standalone/wrappers_c_checks.h

return Alignment == 0 || !isPowerOfTwo(Alignment) ||
          !isAligned(Alignment, sizeof(void *));
 }
 
 // Returns true if calloc(Size, N) overflows on Size*N calculation. Use a
 // builtin supported by recent clang & GCC if it exists, otherwise fallback to a
 // costly division.
 inline bool checkForCallocOverflow(uptr Size, uptr N, uptr *Product) {
 #if __has_builtin(__builtin_umull_overflow) && (SCUDO_WORDSIZE == 64U)
-  return __builtin_umull_overflow(Size, N, Product);
+  return __builtin_umull_overflow(Size, N,
+                                  reinterpret_cast<unsigned long *>(Product));
 #elif __has_builtin(__builtin_umul_overflow) && (SCUDO_WORDSIZE == 32U)
-  return __builtin_umul_overflow(Size, N, Product);
+  // On, e.g. armv7, uptr/uintptr_t may be defined as unsigned long
+  return __builtin_umul_overflow(Size, N,
+                                 reinterpret_cast<unsigned int *>(Product));
 #else
   *Product = Size * N;
   if (!Size)
     return false;
   return (*Product / Size) != N;
 #endif
 }