This is an archive of the discontinued LLVM Phabricator instance.

[Debuginfod] Check libcurl via CMake library.
ClosedPublic

Authored by mysterymath on Mar 15 2022, 10:27 AM.

Details

Summary

If libcurl was built with CMake, CMake's FindCURL module defers
completely to the included config file. This config file doesn't set any
of the variables that the current check script depends on; it just sets
up an imported CMake target. Accordingly, the smoke test fails, since it
can't find the libcurl (or its static dependencies).

This changes the compile smoke test to refer to the imported library
instead; this should in turn bring in the necessary include and library
directories via the interface properties set up by CMake. This better
mirrors the way libcurl is referred to elsewhere in the CMakeLists.

Diff Detail

Event Timeline

mysterymath created this revision.Mar 15 2022, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2022, 10:27 AM
Herald added a subscriber: mgorny. · View Herald Transcript
mysterymath requested review of this revision.Mar 15 2022, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2022, 10:27 AM
MaskRay accepted this revision.Mar 15 2022, 10:36 AM

LGTM.

This revision is now accepted and ready to land.Mar 15 2022, 10:36 AM
This revision was landed with ongoing or failed builds.Mar 15 2022, 11:26 AM
This revision was automatically updated to reflect the committed changes.