This is an archive of the discontinued LLVM Phabricator instance.

Differential D121565

Remove include_directories() from cmake `mlir_tablegen()` function (NFC)
ClosedPublic

Authored by mehdi_amini on Mar 13 2022, 9:15 PM.

Details

Reviewers
stellaraccident
Commits
rG03078ec20b12: Remove include_directories() from cmake `mlir_tablegen()` function (NFC)
Summary

This is present since the beginning, but does not seem needed by any
in-tree target right now. This seems like the kind of thing to populate
by the caller if needed.

Diff Detail

Event Timeline

mehdi_amini created this revision.Mar 13 2022, 9:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2022, 9:15 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 19 others. · View Herald Transcript
mehdi_amini requested review of this revision.Mar 13 2022, 9:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2022, 9:15 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
stellaraccident accepted this revision.Mar 13 2022, 9:21 PM

Thanks

This revision is now accepted and ready to land.Mar 13 2022, 9:21 PM
Harbormaster completed remote builds in B154024: Diff 414980.Mar 13 2022, 9:30 PM
Closed by commit rG03078ec20b12: Remove include_directories() from cmake `mlir_tablegen()` function (NFC) (authored by mehdi_amini). · Explain WhyMar 13 2022, 9:36 PM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG03078ec20b12: Remove include_directories() from cmake `mlir_tablegen()` function (NFC).
dtzWill added a subscriber: dtzWill.Mar 19 2022, 1:04 PM

Revision Contents

PathSize
mlir/
cmake/
modules/
1 line

Diff 414983

mlir/cmake/modules/AddMLIR.cmake

include(GNUInstallDirs) include(GNUInstallDirs)
include(LLVMDistributionSupport) include(LLVMDistributionSupport)
function(mlir_tablegen ofn) function(mlir_tablegen ofn)
tablegen(MLIR ${ARGV}) tablegen(MLIR ${ARGV})
set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn} set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn}
PARENT_SCOPE) PARENT_SCOPE)
include_directories(${CMAKE_CURRENT_BINARY_DIR})
endfunction() endfunction()
# Declare a dialect in the include directory # Declare a dialect in the include directory
function(add_mlir_dialect dialect dialect_namespace) function(add_mlir_dialect dialect dialect_namespace)
set(LLVM_TARGET_DEFINITIONS ${dialect}.td) set(LLVM_TARGET_DEFINITIONS ${dialect}.td)
mlir_tablegen(${dialect}.h.inc -gen-op-decls) mlir_tablegen(${dialect}.h.inc -gen-op-decls)
mlir_tablegen(${dialect}.cpp.inc -gen-op-defs) mlir_tablegen(${dialect}.cpp.inc -gen-op-defs)
mlir_tablegen(${dialect}Types.h.inc -gen-typedef-decls -typedefs-dialect=${dialect_namespace}) mlir_tablegen(${dialect}Types.h.inc -gen-typedef-decls -typedefs-dialect=${dialect_namespace})
▲ Show 20 Lines • Show All 446 Lines • Show Last 20 Lines