This adds support for documenting the top-level "symbols",
e.g. patterns, constraints, rewrites, etc., within a PDLL file.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Tools/mlir-pdll-lsp-server/LSPServer.cpp | ||
---|---|---|
102 | Why/What is the consequence of this? And if we restricted to just top-level for symbol would this be useful for where hierarchical is not supported? | |
mlir/lib/Tools/mlir-pdll-lsp-server/PDLLServer.cpp | ||
528 | Could you expand here how this relates to the below assignment? (I don't quite follow how using the nameLoc as the bodyLoc helps here or changes behavior, I'm guessing that it now points to place of template definition) |
mlir/lib/Tools/mlir-pdll-lsp-server/LSPServer.cpp | ||
---|---|---|
102 | It changes how we need to construct the symbol set, and I don't have access to an IDE that doesn't support hierarchical to see/decide what is actually useful there. For now though, PDLL doesn't have nested symbols so I just removed the optionality here (this was copied from the MLIR server). | |
mlir/lib/Tools/mlir-pdll-lsp-server/PDLLServer.cpp | ||
528 | Thanks for calling this out, this isn't necessary at this point. It's part of template support, which is a later addition (and would actually make sense when seeing the template code). |
Why/What is the consequence of this? And if we restricted to just top-level for symbol would this be useful for where hierarchical is not supported?