This is an archive of the discontinued LLVM Phabricator instance.

[mlir][SCF] Implement RegionBranchOpInterface on ExecuteRegionOp
ClosedPublic

Authored by springerm on Mar 12 2022, 8:52 AM.

Details

Summary

This is needed for the BufferDeallocation pass.

Depends On D121522

Diff Detail

Event Timeline

springerm created this revision.Mar 12 2022, 8:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2022, 8:52 AM
springerm requested review of this revision.Mar 12 2022, 8:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2022, 8:52 AM
bondhugula added inline comments.
mlir/lib/Dialect/SCF/SCF.cpp
253

Stale comment? This will never branch back to itself.

springerm marked an inline comment as done.Mar 12 2022, 10:04 AM
springerm added inline comments.
mlir/lib/Dialect/SCF/SCF.cpp
253

ahh yes, copy pasta

springerm marked an inline comment as done.

update

nicolasvasilache accepted this revision.Mar 16 2022, 1:08 AM
This revision is now accepted and ready to land.Mar 16 2022, 1:08 AM
This revision was landed with ongoing or failed builds.Mar 16 2022, 3:56 AM
This revision was automatically updated to reflect the committed changes.