This is an archive of the discontinued LLVM Phabricator instance.

[libc] Implement exp2f function that is correctly rounded for all rounding modes.
ClosedPublic

Authored by lntue on Mar 11 2022, 7:16 AM.

Details

Summary

Implement exp2f function that is correctly rounded for all rounding modes.

Diff Detail

Event Timeline

lntue created this revision.Mar 11 2022, 7:16 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 11 2022, 7:16 AM
lntue requested review of this revision.Mar 11 2022, 7:16 AM
lntue updated this revision to Diff 414668.Mar 11 2022, 8:20 AM

Fix unit test.

sivachandra accepted this revision.Mar 13 2022, 10:45 PM

Do you have any performance numbers comparing before and after?

This revision is now accepted and ready to land.Mar 13 2022, 10:45 PM
zimmermann6 accepted this revision.Mar 14 2022, 2:42 AM

ok for me too, all exhaustive tests do pass!

lntue added a comment.Mar 14 2022, 6:41 AM

Do you have any performance numbers comparing before and after?

The new implementation is about 10-15% faster than the previous one.

Do you have any performance numbers comparing before and after?

sorry, before and after what?

Do you have any performance numbers comparing before and after?

sorry, before and after what?

The question was for @lntue. This patch changes the exp2f implementation, so my question was to understand if the new implementation affects performance.