[lldb] Add a getter for the process' system architecture

[JDevlieghere]

Summary

This patch adds a getter for the process' system architecture. I went with Process::GetSystemArchitecture to match Platform::GetSystemArchitecture.

[labath]

lldb/source/Target/Process.cpp

2654 ↗

(On Diff #414586)

This is only a good default for local process plugins. Since we have just one (windows) of those right now, it might be better to put it there.

[JDevlieghere]

• Only return the host architecture in NativeProcessWindows

[labath]

lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h

75 ↗

(On Diff #414678)

This should go in ProcessWindows.h. NativeProcessWindows is the not-fully-functional lldb-server-based implementation. Also, drop the Process::

[tschuett]

lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp

236 ↗

(On Diff #414678)

two spaces?

[JDevlieghere]

lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp

236 ↗

(On Diff #414678)

I think we have bigger problems than that. But clearly this file isn't getting build for me.

lldb/include/lldb/Target/Process.h

/// UnregisterNotificationCallbacks (const Notifications&)
   ///     true if saved successfully, false if saving the core dump
   ///     is not supported by the plugin, error otherwise.
   virtual llvm::Expected<bool> SaveCore(llvm::StringRef outfile);
 
 protected:
   virtual JITLoaderList &GetJITLoaders();
 
 public:
+  /// Get the system architecture for this process.
+  virtual ArchSpec GetSystemArchitecture() { return {}; }
+
   /// Get the system runtime plug-in for this process.
   ///
   /// \return
   ///   Returns a pointer to the SystemRuntime plugin for this Process
   ///   if one is available.  Else returns nullptr.
   virtual SystemRuntime *GetSystemRuntime();
 
   /// Attach to an existing process using the process attach info.

lldb/source/Plugins/Process/Windows/Common/ProcessWindows.h

public:
 
   bool CanDebug(lldb::TargetSP target_sp,
                 bool plugin_specified_by_name) override;
   bool DestroyRequiresHalt() override { return false; }
   bool DoUpdateThreadList(ThreadList &old_thread_list,
                           ThreadList &new_thread_list) override;
   bool IsAlive() override;
 
+  ArchSpec GetSystemArchitecture override();
+
   size_t DoReadMemory(lldb::addr_t vm_addr, void *buf, size_t size,
                       Status &error) override;
   size_t DoWriteMemory(lldb::addr_t vm_addr, const void *buf, size_t size,
                        Status &error) override;
   lldb::addr_t DoAllocateMemory(size_t size, uint32_t permissions,
                                 Status &error) override;
   Status DoDeallocateMemory(lldb::addr_t ptr) override;
 

lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp

bool ProcessWindows::IsAlive() {
   case eStateExited:
   case eStateInvalid:
     return false;
   default:
     return true;
   }
 }
 
+ArchSpec ProcessWindows::GetSystemArchitecture() {
+  return HostInfo::GetArchitecture();
+}
+
 size_t ProcessWindows::DoReadMemory(lldb::addr_t vm_addr, void *buf,
                                     size_t size, Status &error) {
   size_t bytes_read = 0;
   error = ProcessDebugger::ReadMemory(vm_addr, buf, size, bytes_read);
   return bytes_read;
 }
 
 size_t ProcessWindows::DoWriteMemory(lldb::addr_t vm_addr, const void *buf,

lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

public:
   static void Terminate();
 
   static llvm::StringRef GetPluginNameStatic() { return "gdb-remote"; }
 
   static llvm::StringRef GetPluginDescriptionStatic();
 
   static std::chrono::seconds GetPacketTimeout();
 
+  ArchSpec GetSystemArchitecture() override;
+
   // Check if a given Process
   bool CanDebug(lldb::TargetSP target_sp,
                 bool plugin_specified_by_name) override;
 
   CommandObject *GetPluginCommandObject() override;
 
   // Creating a new process, or attaching to an existing one
   Status WillLaunch(Module *module) override;

lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

if (crash_file_path == nullptr)
     process_sp = std::make_shared<ProcessGDBRemote>(target_sp, listener_sp);
   return process_sp;
 }
 
 std::chrono::seconds ProcessGDBRemote::GetPacketTimeout() {
   return std::chrono::seconds(GetGlobalPluginProperties().GetPacketTimeout());
 }
 
+ArchSpec ProcessGDBRemote::GetSystemArchitecture() {
+  return m_gdb_comm.GetHostArchitecture();
+}
+
 bool ProcessGDBRemote::CanDebug(lldb::TargetSP target_sp,
                                 bool plugin_specified_by_name) {
   if (plugin_specified_by_name)
     return true;
 
   // For now we are just making sure the file exists for a given module
   Module *exe_module = target_sp->GetExecutableModulePointer();
   if (exe_module) {