When addCoalescedPolyhedron was called with j == n - 1,
the polyhedrons-vector was not properly updated (the
IntegerPolyhedron at position n - 2 was "lost"). This patch adds
special handling to that case and a regression testcase.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM.
mlir/lib/Analysis/Presburger/PresburgerSet.cpp | ||
---|---|---|
412–414 | This comment would better fit inside the if condition. |
mlir/lib/Analysis/Presburger/PresburgerSet.cpp | ||
---|---|---|
425–433 | Please add a comment here explaining why it's correct for other possible edge cases with i or j being n - 1 or n - 2. |
This comment would better fit inside the if condition.