This is an archive of the discontinued LLVM Phabricator instance.

Differential D121337

[BOLT][NFC] Fix print-cfg data race
ClosedPublic

Authored by Amir on Mar 9 2022, 1:59 PM.

Details

Reviewers
rafauler
maksfb
Commits
rGd1638cb0b5b2: [BOLT][NFC] Fix print-cfg data race
Summary

Addresses ThreadSanitizer warning

Diff Detail

Event Timeline

Amir created this revision.Mar 9 2022, 1:59 PM
Herald added a reviewer: rafauler. · View Herald TranscriptMar 9 2022, 1:59 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
Amir requested review of this revision.Mar 9 2022, 1:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2022, 1:59 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
Harbormaster completed remote builds in B153436: Diff 414211.Mar 9 2022, 2:05 PM
rafauler accepted this revision.Mar 9 2022, 6:43 PM

Thanks!

This revision is now accepted and ready to land.Mar 9 2022, 6:43 PM
Closed by commit rGd1638cb0b5b2: [BOLT][NFC] Fix print-cfg data race (authored by Amir). · Explain WhyMar 9 2022, 8:28 PM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rGd1638cb0b5b2: [BOLT][NFC] Fix print-cfg data race.

Revision Contents

PathSize
bolt/
lib/
Rewrite/
4 lines

Diff 414269

bolt/lib/Rewrite/RewriteInstance.cpp

Show First 20 Lines • Show All 2,944 Lines • ▼ Show 20 Linesvoid RewriteInstance::buildFunctionsCFG() {
BC->MIB->getOrCreateAnnotationIndex("NOP"); BC->MIB->getOrCreateAnnotationIndex("NOP");
BC->MIB->getOrCreateAnnotationIndex("Size"); BC->MIB->getOrCreateAnnotationIndex("Size");
ParallelUtilities::WorkFuncWithAllocTy WorkFun = ParallelUtilities::WorkFuncWithAllocTy WorkFun =
[&](BinaryFunction &BF, MCPlusBuilder::AllocatorIdTy AllocId) { [&](BinaryFunction &BF, MCPlusBuilder::AllocatorIdTy AllocId) {
if (!BF.buildCFG(AllocId)) if (!BF.buildCFG(AllocId))
return; return;
if (opts::PrintAll) if (opts::PrintAll) {
auto L = BC->scopeLock();
BF.print(outs(), "while building cfg", true); BF.print(outs(), "while building cfg", true);
}
}; };
ParallelUtilities::PredicateTy SkipPredicate = [&](const BinaryFunction &BF) { ParallelUtilities::PredicateTy SkipPredicate = [&](const BinaryFunction &BF) {
return !shouldDisassemble(BF) || !BF.isSimple(); return !shouldDisassemble(BF) || !BF.isSimple();
}; };
ParallelUtilities::runOnEachFunctionWithUniqueAllocId( ParallelUtilities::runOnEachFunctionWithUniqueAllocId(
*BC, ParallelUtilities::SchedulingPolicy::SP_INST_LINEAR, WorkFun, *BC, ParallelUtilities::SchedulingPolicy::SP_INST_LINEAR, WorkFun,
▲ Show 20 Lines • Show All 2,560 Lines • Show Last 20 Lines