This is an archive of the discontinued LLVM Phabricator instance.

[debug-info] Debug salvage llvm.dbg.addr in original function that point into the coroutine frame when splitting coros.
ClosedPublic

Authored by gottesmm on Mar 9 2022, 11:59 AM.

Details

Summary

We are already doing this in the split functions while we clone. This just
handles the original function.

I also updated the coroutine split test to validate that we are always referring
to the msg in the context object instead of in a shadow copy.

rdar://83957028

Diff Detail

Event Timeline

gottesmm created this revision.Mar 9 2022, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2022, 11:59 AM
gottesmm requested review of this revision.Mar 9 2022, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2022, 11:59 AM

Adrian, can you review?

aprantl accepted this revision.Mar 9 2022, 12:45 PM

This is like https://reviews.llvm.org/D121324, but I like this test more.

This revision is now accepted and ready to land.Mar 9 2022, 12:45 PM
gottesmm updated this revision to Diff 414191.Mar 9 2022, 12:55 PM

Updated some tests.

Tests passed on both linux/windows. Going to merge this!

This revision was landed with ongoing or failed builds.Mar 9 2022, 2:02 PM
This revision was automatically updated to reflect the committed changes.