This is an archive of the discontinued LLVM Phabricator instance.

[libc][bazel] split support_standalone_cpp target
ClosedPublic

Authored by michaelrj on Mar 9 2022, 11:04 AM.

Details

Summary

previously the support_standalone_cpp target contained all of the files
in the __support/cpp folder. This change splits these out so that only
what is needed is included. In addition, this change adds the new
support files that previously didn't have targets.

Diff Detail

Event Timeline

michaelrj created this revision.Mar 9 2022, 11:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2022, 11:04 AM
michaelrj requested review of this revision.Mar 9 2022, 11:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2022, 11:04 AM
michaelrj updated this revision to Diff 414173.Mar 9 2022, 11:35 AM

fix errors

lntue accepted this revision.Mar 9 2022, 11:56 AM
This revision is now accepted and ready to land.Mar 9 2022, 11:56 AM
gchatelet accepted this revision.Mar 10 2022, 2:23 AM
gchatelet added inline comments.
utils/bazel/llvm-project-overlay/libc/BUILD.bazel
88–90

[nit] Can we make the hdrs field a one liner?

michaelrj updated this revision to Diff 415635.Mar 15 2022, 4:39 PM

address comments

This revision was landed with ongoing or failed builds.Mar 15 2022, 4:40 PM
This revision was automatically updated to reflect the committed changes.