This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][CUDA] Remove hard thread limit in the plugin
AbandonedPublic

Authored by tianshilei1992 on Mar 8 2022, 2:30 PM.

Details

Reviewers
jdoerfert
jhuber6
Summary

OpenMP specification doesn't limit the max number of threads a team can
use. Like we did in D119313 to remove the hard limit of number of teams, we also
do it for number of threads.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Mar 8 2022, 2:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 2:30 PM
tianshilei1992 requested review of this revision.Mar 8 2022, 2:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 2:30 PM

OpenMP doesn't say we need to use as many threads as the user wants either. Do we ask the hardware what it can do?

OpenMP doesn't say we need to use as many threads as the user wants either. Do we ask the hardware what it can do?

Yes. That's what ThreadsPerBlock is for.

tianshilei1992 abandoned this revision.Mar 8 2022, 3:37 PM

Move to D121262 for more cleanup.